Skip to content

ci: Fix unit test summary #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chtruong814 merged 5 commits into from
Apr 4, 2025
Merged

ci: Fix unit test summary #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccee268
ci: Fix unit test summary in GHA
chtruong814 Apr 3, 2025
9b69881
Merge remote-tracking branch 'origin/main' into chtruong/unit-test-su…
chtruong814 Apr 3, 2025
66d2c0e
Merge branch 'main' into chtruong/unit-test-summary
terrykong Apr 3, 2025
0724806
Add DCO placeholder check for merge queue
chtruong814 Apr 4, 2025
ddf6f80
Revert "Add DCO placeholder check for merge queue"
chtruong814 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/_run_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ jobs:
--env HF_DATASETS_CACHE=/home/TestData/reinforcer/hf_datasets_cache \
--env REINFORCER_REPO_DIR=/opt/reinforcer \
--env HF_TOKEN \
--env GITHUB_STEP_SUMMARY \
--volume $GITHUB_ACTION_DIR:$GITHUB_ACTION_DIR \
--volume /mnt/datadrive/TestData/reinforcer/datasets:/opt/reinforcer/datasets:ro \
--volume /mnt/datadrive/TestData/reinforcer/checkpoints:/home/TestData/reinforcer/checkpoints:ro \
Expand Down Expand Up @@ -112,7 +111,7 @@ jobs:
${{ inputs.AFTER_SCRIPT }}
RUN_TEST_EOF
)
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "$cmd"
docker exec --env GITHUB_STEP_SUMMARY nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "$cmd"

- name: final_script_external
if: always() && inputs.FINAL_SCRIPT_EXTERNAL != ':'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cicd-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,12 @@ jobs:
# uv run --no-sync bash ./tests/functional/grpo.sh
AFTER_SCRIPT: |
cd /opt/reinforcer
cat <<EOF
cat <<EOF | tee -a $GITHUB_STEP_SUMMARY
# Unit test results
\`\`\`json
$(cat tests/unit/unit_results.json || echo "n/a")
\`\`\`
EOF | tee -a $GITHUB_STEP_SUMMARY
EOF
secrets:
HF_TOKEN: ${{ secrets.HF_TOKEN }}

Expand Down
3 changes: 3 additions & 0 deletions docker/Dockerfile
View file
Open in desktop
Comment thread
terrykong marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,7 @@ sed -i '/# >>> conda initialize >>>/,/# <<< conda initialize <<</ { /^[^#]/ s/^/

# Comment out any line that explicitly exports the anaconda3 PATH
sed -i '/export PATH=\$HOME\/anaconda3\/bin:\$PATH/ s/^/# /' ~/.bashrc

# Enable the repo's git history within the container
git config --global --add safe.directory /opt/reinforcer
EOF