chore: major version bump (torch 2.8, vllm 0.11, ray 2.49) & SP fixes#1334
chore: major version bump (torch 2.8, vllm 0.11, ray 2.49) & SP fixes#1334
Conversation
520195d to
cb73810
Compare
ℹ️ File Consistency CheckCheck based on commit: cb73810 (PR #1334 from ✅ DTensor Policy Worker Synchronization CheckBoth DTensor policy worker files were modified in this PR:
Please ensure that the changes are consistent between both files where applicable. This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning. |
ℹ️ File Consistency CheckCheck based on commit: 92e34fe (PR #1334 from ✅ DTensor Policy Worker Synchronization CheckBoth DTensor policy worker files were modified in this PR:
Please ensure that the changes are consistent between both files where applicable. This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning. |
ℹ️ File Consistency CheckCheck based on commit: 0886c0f (PR #1334 from ✅ DTensor Policy Worker Synchronization CheckBoth DTensor policy worker files were modified in this PR:
Please ensure that the changes are consistent between both files where applicable. This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning. |
ℹ️ File Consistency CheckCheck based on commit: 604f51d (PR #1334 from ✅ DTensor Policy Worker Synchronization CheckBoth DTensor policy worker files were modified in this PR:
Please ensure that the changes are consistent between both files where applicable. This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning. |
|
Hi @terrykong, I am having error in |
I am also experiencing several issues when trying to get my python environment setup after the changes introduced in this PR!! |
|
@youngeunkwon0405 @afennelly-mitre In both of your cases it's due to Just a heads up that I am aware that this change also made the dependency resolution tempermental. If you run into an error like this for causal-conv1d or any of the ones with extra-build-denepdencies: I believe the fix is this: d7a3e40 (see only the change to the |
@terrykong what cuda version was used with the provided major version updates to things like torch and vllm? I'm having different issues when using cuda 12.5 and cuda 12.6 Trying to figure out if it's simply related to me needing a higher cuda version, or fixing something else with my environment setup. |
|
@afennelly-mitre our docker image uses 12.9. Local/bare-metal it's hard to support a large version skew, so I can imagine you might run into issues if the version is too far off or not an LTS version. I would recommend upgrading to 12.9, or if that is prohibitive on your workstation, I would encourage to use the container. |
…#1334) Signed-off-by: Terry Kong <terryk@nvidia.com>
…#1334) Signed-off-by: Terry Kong <terryk@nvidia.com>
…#1334) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
…#1334) Signed-off-by: Terry Kong <terryk@nvidia.com>
…#1334) Signed-off-by: Terry Kong <terryk@nvidia.com>
…NVIDIA-NeMo#1334) Signed-off-by: Terry Kong <terryk@nvidia.com>
…NVIDIA-NeMo#1334) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>

What does this PR do ?
Upgrades
Changes
Issues
List issues that this PR closes (syntax):
Closes #1122 #818
closes #532
Will be broken once we upgrade:
Will be unblocked by this PR:
TP==1#773Tests
converge logs
big-version-bump.log
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores