Skip to content

build: Bump setuptools >= 80.10.1 and wheel >= 0.46.2#1822

Merged
chtruong814 merged 4 commits intomainfrom
chtruong/bump-wheel
Jan 25, 2026
Merged

build: Bump setuptools >= 80.10.1 and wheel >= 0.46.2#1822
chtruong814 merged 4 commits intomainfrom
chtruong/bump-wheel

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

@chtruong814 chtruong814 commented Jan 23, 2026

What does this PR do ?

build: Bump setuptools >= 80.10.1 and wheel >= 0.46.2 to address CVEs

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated dependency constraints to ensure improved compatibility and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner January 23, 2026 18:09
@chtruong814 chtruong814 added the CI:L1 Run doctests, unit tests, and functional tests label Jan 23, 2026
terrykong
terrykong previously approved these changes Jan 23, 2026
@terrykong
Copy link
Copy Markdown
Collaborator

@chtruong814 looks like the lock file wasn't updated properly

@chtruong814
Copy link
Copy Markdown
Contributor Author

face palm. Need to also commit the pyproject.toml

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

Dependency version constraints updated in pyproject.toml. Added setuptools>=80.10.1 to override-dependencies and wheel>=0.46.2 to constraint-dependencies.

Changes

Cohort / File(s) Summary
Dependency version constraints
pyproject.toml
Updated override-dependencies with setuptools>=80.10.1 and constraint-dependencies with wheel>=0.46.2

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • terrykong
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: bumping setuptools and wheel dependency versions to address CVEs, which aligns with both the file changes and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed The PR contains minor dependency version updates to address CVEs in setuptools and wheel, not major changes requiring test documentation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 259-260: Update build-system.requires to pin wheel to a safe
minimum by adding "wheel>=0.46.2" alongside the existing "setuptools>=80.10.1"
so PEP 517 builds cannot select vulnerable wheel versions; ensure the same
constraint also appears where constraint-dependencies are defined (the existing
constraint-dependencies entry for wheel) so both build-system.requires and the
constraint list consistently enforce wheel>=0.46.2.

Comment thread pyproject.toml Outdated
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 23, 2026
@terrykong terrykong enabled auto-merge (squash) January 25, 2026 00:06
@chtruong814
Copy link
Copy Markdown
Contributor Author

The CI passed on the latest commit here. Github is showing no tests ran because it reset after adding the cherry-pick label.
https://github.com/NVIDIA-NeMo/RL/actions/runs/21302726061

@chtruong814 chtruong814 disabled auto-merge January 25, 2026 15:51
@chtruong814 chtruong814 merged commit 94512d6 into main Jan 25, 2026
54 of 56 checks passed
@chtruong814 chtruong814 deleted the chtruong/bump-wheel branch January 25, 2026 15:51
chtruong814 added a commit that referenced this pull request Jan 25, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
yuki-97 pushed a commit that referenced this pull request Jan 26, 2026
#1825)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
yfw pushed a commit that referenced this pull request Feb 9, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
xavier-owkin pushed a commit to owkin/Owkin-NeMo-RL that referenced this pull request Feb 10, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
xavier-owkin pushed a commit to owkin/Owkin-NeMo-RL that referenced this pull request Feb 10, 2026
… into r0.5.0 (NVIDIA-NeMo#1825)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 12, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
avenkateshha pushed a commit to avenkateshha/RL that referenced this pull request Apr 10, 2026
… into r0.5.0 (NVIDIA-NeMo#1825)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests r0.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants