build: Bump setuptools >= 80.10.1 and wheel >= 0.46.2#1822
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
|
@chtruong814 looks like the lock file wasn't updated properly |
|
face palm. Need to also commit the pyproject.toml |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
📝 WalkthroughWalkthroughDependency version constraints updated in pyproject.toml. Added setuptools>=80.10.1 to override-dependencies and wheel>=0.46.2 to constraint-dependencies. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 259-260: Update build-system.requires to pin wheel to a safe
minimum by adding "wheel>=0.46.2" alongside the existing "setuptools>=80.10.1"
so PEP 517 builds cannot select vulnerable wheel versions; ensure the same
constraint also appears where constraint-dependencies are defined (the existing
constraint-dependencies entry for wheel) so both build-system.requires and the
constraint list consistently enforce wheel>=0.46.2.
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
|
The CI passed on the latest commit here. Github is showing no tests ran because it reset after adding the cherry-pick label. |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
#1825) Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
… into r0.5.0 (NVIDIA-NeMo#1825) Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
… into r0.5.0 (NVIDIA-NeMo#1825) Signed-off-by: Charlie Truong <chtruong@nvidia.com>
What does this PR do ?
build: Bump setuptools >= 80.10.1 and wheel >= 0.46.2 to address CVEs
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.