Skip to content

cp: Update setuptools to 80.10.2 #1830 into r0.5.0#1831

Merged
chtruong814 merged 1 commit intor0.5.0from
chtruong/r0.5.0-setuptools
Jan 27, 2026
Merged

cp: Update setuptools to 80.10.2 #1830 into r0.5.0#1831
chtruong814 merged 1 commit intor0.5.0from
chtruong/r0.5.0-setuptools

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

@chtruong814 chtruong814 commented Jan 27, 2026

What does this PR do ?

Cherry-pick for #1830

This had to be manually created to resolve cherry-pick conflicts.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Bug Fixes
    • Updated a critical development dependency to address a security vulnerability.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner January 27, 2026 03:38
@chtruong814 chtruong814 changed the title build: Update setuptools to 80.10.2 cp: Update setuptools to 80.10.2 #1830 into r0.5.0 Jan 27, 2026
@chtruong814 chtruong814 added the CI:L1 Run doctests, unit tests, and functional tests label Jan 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

This PR updates the setuptools dependency constraint in pyproject.toml from version 80.10.1 to 80.10.2 within the uv tool's override-dependencies configuration, adding a comment explaining the CVE rationale for the version requirement.

Changes

Cohort / File(s) Summary
Dependency version bump
pyproject.toml
Updated setuptools override-dependency constraint from >=80.10.1 to >=80.10.2 with added CVE explanatory comment

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

CI:L1, r0.5.0

Suggested reviewers

  • terrykong
  • yuki-97
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions updating setuptools to 80.10.2 but includes 'cp: Update setuptools to 80.10.2 #1830 into r0.5.0', which contains extraneous information (issue reference, branch details) and uses unclear prefix notation. Simplify the title to 'Update setuptools to 80.10.2' or 'build: Update setuptools to 80.10.2' to focus on the main change without branch/PR reference noise.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only a minor security patch dependency bump for setuptools (>=80.10.1 to >=80.10.2), which satisfies the check criteria allowing pass for minor changes without requiring test documentation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chtruong814 chtruong814 merged commit 3cca19c into r0.5.0 Jan 27, 2026
60 of 64 checks passed
@chtruong814 chtruong814 deleted the chtruong/r0.5.0-setuptools branch January 27, 2026 18:23
xavier-owkin pushed a commit to owkin/Owkin-NeMo-RL that referenced this pull request Feb 10, 2026
avenkateshha pushed a commit to avenkateshha/RL that referenced this pull request Apr 10, 2026
…-NeMo#1831)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants