feat: optimize refit by preparing refit info ahead of time#638
Merged
feat: optimize refit by preparing refit info ahead of time#638
Conversation
Contributor
|
@YUki-666 |
61abcf9 to
de56749
Compare
de56749 to
f57e799
Compare
f57e799 to
fc4d64e
Compare
Contributor
Author
Yup, I added it in ebb874a. |
ZhiyuLi-Nvidia
previously approved these changes
Jul 11, 2025
Contributor
ZhiyuLi-Nvidia
left a comment
There was a problem hiding this comment.
Thank you @YUki-666. LGTM!
9c0e833 to
e9b22fd
Compare
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
…mcore for speedup Signed-off-by: Yuki Huang <yukih@nvidia.com>
c685241 to
f152f61
Compare
yfw
reviewed
Jul 16, 2025
4 tasks
yfw
reviewed
Jul 16, 2025
yfw
previously approved these changes
Jul 16, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
ZhiyuLi-Nvidia
approved these changes
Jul 16, 2025
yfw
approved these changes
Jul 16, 2025
terrykong
approved these changes
Jul 16, 2025
ZhiyuLi-Nvidia
pushed a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
…Mo#638) Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
yaoyu-33
added a commit
that referenced
this pull request
Jul 28, 2025
)" This reverts commit 8f7d71e
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
…Mo#638) Signed-off-by: Yuki Huang <yukih@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…Mo#638) Signed-off-by: Yuki Huang <yukih@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…Mo#638) Signed-off-by: Yuki Huang <yukih@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
…Mo#638) Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the refit process changes from #613.
What does this PR do ?
e_score_correction_bias) will change during training, have some special handle with it, andrefit_param_info_mcoreis not cached for now because of this.Test Result
convergence
time cost
In mcore w/ packing (dsv3 w/ 64 tp)
*The ~20s overhead is due to offload.

Refit Process Changes
Colocated
Previous
prepare_weights_for_ipcin train side.get_weights_ipc_handlesin train side andupdate_weights_from_ipc_handlesin inference side.Now
prepare_refit_infoin train side.prepare_weights_for_ipcin train side.get_weights_ipc_handlesin train side andupdate_weights_from_ipc_handlesin inference side.Non-colocated
Previous
init_collectivein both train and inference side.prepare_info_for_collectivein train side.broadcast_weights_for_collectivein train side andupdate_weights_from_collectivein inference side.Now
init_collectivein both train and inference side.prepare_refit_infoin both train and inference side.broadcast_weights_for_collectivein train side andupdate_weights_from_collectivein inference side.