fix: maintain fp32 mlp.router.expert_bias even with bf16 enabled#674
Closed
ZhiyuLi-Nvidia wants to merge 14 commits intomainfrom
Closed
fix: maintain fp32 mlp.router.expert_bias even with bf16 enabled#674ZhiyuLi-Nvidia wants to merge 14 commits intomainfrom
ZhiyuLi-Nvidia wants to merge 14 commits intomainfrom
Conversation
061c3fc to
72ceb4f
Compare
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
…mcore for speedup Signed-off-by: Yuki Huang <yukih@nvidia.com>
c685241 to
f152f61
Compare
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
72ceb4f to
a6018ab
Compare
Contributor
|
Target to yukih/prepare-refit-info first for comparing the modification easily. |
yfw
previously approved these changes
Jul 16, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
fd433d3 to
ad1d3ba
Compare
Contributor
Author
|
Close thie PR since it is part of #686. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fix: maintain fp32 mlp.router.expert_bias even with bf16 enabled
model.layers.x.mlp.gate.e_score_correction_biasdtype is changing between step 1 to the following steps, which make it impossible to cache para dtype with inconsistency issue:Details
model.layers.x.mlp.gate.e_score_correction_biasoriginates fromdecoder.layers.x.mlp.router.expert_bias in mcoredecoder.layers.x.mlp.router.expert_biasshould be starting with fp32 here and always fp32 hereavoid serializing rebuild_cuda_tensor function
serializing funciton is costly in transfer cudaipc between workers. Got some performance improvement with the change.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information