Skip to content

TransformReplay::replayCasP sets the right contiguity.#1291

Merged
wujingyue merged 7 commits intomainfrom
fix1290
Nov 17, 2023
Merged

TransformReplay::replayCasP sets the right contiguity.#1291
wujingyue merged 7 commits intomainfrom
fix1290

Conversation

@wujingyue
Copy link
Collaborator

@wujingyue wujingyue commented Nov 14, 2023

Fixes #1290

@wujingyue wujingyue linked an issue Nov 14, 2023 that may be closed by this pull request
The pointwise scheduler changes contiguity of fusion outputs. #1290
Closed
@wujingyue wujingyue requested a review from jjsjann123 November 14, 2023 01:14
@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 14, 2023

!build

@wujingyue wujingyue added the bug label Nov 14, 2023
@wujingyue wujingyue mentioned this pull request Nov 14, 2023
Merged
@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 14, 2023

!build

1 similar comment
@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 14, 2023

!build

naoyam
naoyam reviewed Nov 14, 2023
View reviewed changes
jjsjann123
jjsjann123 reviewed Nov 14, 2023
View reviewed changes
wujingyue
wujingyue commented Nov 15, 2023
View reviewed changes
@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 15, 2023

!build

1 similar comment
@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 16, 2023

!build

@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 17, 2023

Can someone review this again? It's blocking #1281, #1295 and #1321.

@wujingyue
Copy link
Collaborator Author

wujingyue commented Nov 17, 2023

!build

@wujingyue wujingyue merged commit 8ba6201 into main Nov 17, 2023
@wujingyue wujingyue deleted the fix1290 branch November 17, 2023 17:51
wujingyue added a commit that referenced this pull request Nov 26, 2023
@wujingyue
Assert TransformReplay::replayCasP only replays allocation for Set.
e53530e 
As a follow up to #1291.
@wujingyue wujingyue mentioned this pull request Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zasdfgbnm zasdfgbnm zasdfgbnm approved these changes

@jjsjann123 jjsjann123 Awaiting requested review from jjsjann123

@naoyam naoyam Awaiting requested review from naoyam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The pointwise scheduler changes contiguity of fusion outputs.

4 participants

@wujingyue @naoyam @zasdfgbnm @jjsjann123