s/PointerCast/PointerArithmetic.#1321
Merged
jjsjann123 merged 1 commit intowjy/slicefrom Nov 17, 2023
Merged
Conversation
With slices, the pointer address might not be the same. PointerArithmetic is more accurate.
jjsjann123
approved these changes
Nov 17, 2023
Collaborator
Author
|
Err… don’t merge this into a fork of mine ;) I want to keep PRs small.
Never mind I’ll fix this one!
…On Fri, Nov 17, 2023 at 8:42 AM jjsjann123 ***@***.***> wrote:
Merged #1321 <#1321> into wjy/slice.
—
Reply to this email directly, view it on GitHub
<#1321 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVE5BBUWMBPUR7IPM7QGI3YE6HX3AVCNFSM6AAAAAA7O7IEZ2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHE4TMNRWGM4DOOI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
Oops, my bad. didn't notice this is targetting a fork. 🙇 |
wujingyue
added a commit
that referenced
this pull request
Nov 17, 2023
With slices, the pointer address might not be the same. PointerArithmetic is more accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With slices, the pointer address might not be the same. PointerArithmetic is more accurate.