IdModel: Fix inconsistent graph issue #1627
Merged
naoyam merged 13 commits intoIterDomainGraphsfrom Jan 18, 2024
Merged
Conversation
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
naoyam
changed the title
Collaborator
Author
|
!build |
naoyam
changed the title
Collaborator
Author
|
!build |
This was referenced Jan 18, 2024
naoyam
added a commit
that referenced
this pull request
Jan 22, 2024
Previously IdModel constructor builds all graphs at once. Now each graph can be built individually. This refactoring is done in preparation for loop promotion analysis to allow testing of each step of the analysis. It would also be useful as sometimes not all graphs would be necessary to build. Stacked on #1627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1636
Previously when exprs are merged, their input and output groups are updated to point to the new merged group. However, this is not enough as there may be val groups that are used or defined by the pre-merged expr groups but they may not be inputs or outputs of the exprs. See #1636 for a concrete example.
Here, we check all mapping entries of
unique_definitions_andunique_uses_so all uses and definitions are correctly updated.