Skip to content

[IdModel] Cherry pick #1627#1644

Merged
naoyam merged 4 commits intomainfrom
idmodel_fix_inconsistent_graph
Jan 21, 2024
Merged

[IdModel] Cherry pick #1627#1644
naoyam merged 4 commits intomainfrom
idmodel_fix_inconsistent_graph

Conversation

@naoyam
Copy link
Collaborator

@naoyam naoyam commented Jan 18, 2024

There's a bug I found in the main IdModel branch (#32). See #1627 and #1636. This PR is just cherry-picking #1627.

@naoyam
Copy link
Collaborator Author

naoyam commented Jan 18, 2024

!build

@naoyam
Copy link
Collaborator Author

naoyam commented Jan 18, 2024

!build

@naoyam naoyam changed the title [IdModel] [WIP] Cherry pick #1627 [IdModel] Cherry pick #1627 Jan 18, 2024
@naoyam naoyam marked this pull request as ready for review January 18, 2024 22:59
@naoyam naoyam added the idmodel label Jan 18, 2024
@naoyam naoyam requested a review from jacobhinkle January 18, 2024 23:01
Copy link
Collaborator

@jacobhinkle jacobhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naoyam naoyam merged commit ee866bd into main Jan 21, 2024
@naoyam naoyam deleted the idmodel_fix_inconsistent_graph branch January 21, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants