IdModel: Loop Promotion Analysis Step 1: Build a map of broadcast resolutions for root domains#1650
Merged
IdModel: Loop Promotion Analysis Step 1: Build a map of broadcast resolutions for root domains#1650
Conversation
Previously IdModel constructor builds all graphs at once. This refactoring is done in preparation for loop promotion analysis to allow testing of each step of the analysis
This is the first step of the loop promotion analysis. It may not be very clear what this analysis is intended to do at this point, but in short, the root resolution information is propagated to intermediate and leaf ID groups in the IEL graph, which is then projected back to the loop graph. I thought before diving into the full promotion analysis it would make reviewing easier to split this part off as the first sub-PR with unit tests.
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
naoyam
changed the title
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
zasdfgbnm
reviewed
Feb 15, 2024
zasdfgbnm
reviewed
Feb 16, 2024
zasdfgbnm
approved these changes
Feb 16, 2024
Collaborator
zasdfgbnm
left a comment
zasdfgbnm
left a comment
There was a problem hiding this comment.
Finished reading, don't see any blocking issue.
naoyam
added a commit
that referenced
this pull request
May 10, 2024
This is the final step of the loop promotion analysis. The promotion map is almost completed at Step 3, but some partially inlined domains need one more propagation, which is done by Step 4 and Step 5. Step 5 is mostly just a repeat of Step 3. This basically concludes the loop promotion analysis, although there are a couple of issues that were found while working on indexing (#2218). Those issues will be addressed as further follow-up PRs. - Step 1: #1650 - Step 2: #1777 - Step 3: #1830 - Step 4: #2003
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step of the loop promotion analysis. It may not be very clear what this analysis is intended to do at this point, but in short, the root resolution information is propagated to intermediate and leaf ID groups in the IEL graph, which is then projected back to the loop graph. I thought before diving into the full promotion analysis it would make reviewing easier to split this part off as the first sub-PR with unit tests.
There's a detailed design doc for the overall loop promotion analysis. DM me.