Skip serializing FusionKernelRuntime if it is not compiled#1875
Closed
Skip serializing FusionKernelRuntime if it is not compiled#1875
FusionKernelRuntime if it is not compiled#1875Conversation
Collaborator
Author
|
!build |
Collaborator
|
sorry somehow forgot about this one. |
jjsjann123
reviewed
Mar 11, 2024
Collaborator
jjsjann123
left a comment
jjsjann123
left a comment
There was a problem hiding this comment.
QQ: was this the case for a no-op fusion or something?
Is there an existing test failure that this PR patches, otherwise, can we add a python test as well.
Collaborator
Author
|
!build |
jjsjann123
approved these changes
Mar 19, 2024
Collaborator
jjsjann123
left a comment
jjsjann123
left a comment
There was a problem hiding this comment.
stamping just to keep CI green.
Collaborator
|
!build |
Collaborator
Author
|
Replace with #2061 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids the following error when the
FusionKernelRuntimeis not compiled in serde test suite.