Skip to content

Fix serialization errors when skipping compilation in FusionExecutor. #2061

Merged
rdspring1 merged 18 commits intopm/skip_compilationfrom
skip_compilation_serde_fix
Apr 22, 2024
Merged

Fix serialization errors when skipping compilation in FusionExecutor. #2061
rdspring1 merged 18 commits intopm/skip_compilationfrom
skip_compilation_serde_fix

Conversation

@rdspring1
Copy link
Collaborator

Serialization assumes that FusionExecutor always contains a compiled kernel. This PR updates serialization to skip compilation correctly.

@rdspring1
Copy link
Collaborator Author

!build

@rdspring1 rdspring1 requested a review from Priya2698 April 10, 2024 23:06
@rdspring1
Copy link
Collaborator Author

!build

@Priya2698
Copy link
Collaborator

General question: How does nvFuser handle if only one out of the many segments is not compiled? Do we skip serialization/deserialization for the entire fusion or is it segment-wise?

@rdspring1
Copy link
Collaborator Author

General question: How does nvFuser handle if only one out of the many segments is not compiled? Do we skip serialization/deserialization for the entire fusion or is it segment-wise?

We're skipping on a FusionExecutor basis, so it is segment-wise. Serialization follows the same behavior.

@rdspring1 rdspring1 marked this pull request as ready for review April 11, 2024 20:37
@Priya2698
Copy link
Collaborator

There are some new issues on my branch. I prefer either merging this to main or first fixing the issues in my branch so the root cause is clear. Wdyt?

@Priya2698
Copy link
Collaborator

!build

@rdspring1
Copy link
Collaborator Author

This PR can wait until the issues in your branch are fixed.

@Priya2698 Priya2698 force-pushed the pm/skip_compilation branch from 94e037c to 015f0e5 Compare April 19, 2024 21:37
@Priya2698
Copy link
Collaborator

This PR can wait until the issues in your branch are fixed.

@rdspring1 We can merge this into my branch now. Could you resolve the conflicts, and finalize this PR? Thanks for the fix!

@rdspring1
Copy link
Collaborator Author

!build

Copy link
Collaborator

@Priya2698 Priya2698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added minor comments.

@rdspring1 rdspring1 merged commit d91acc2 into pm/skip_compilation Apr 22, 2024
@rdspring1 rdspring1 deleted the skip_compilation_serde_fix branch April 22, 2024 19:27
Priya2698 pushed a commit that referenced this pull request Apr 24, 2024
…`. (#2061)

Serialization assumes that `FusionExecutor` always contains a compiled
kernel. This PR updates serialization to skip compilation correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants