Skip to content

fix(cli): use correct openshell logs subcommand#267

Closed
mihai-chiorean wants to merge 1 commit intoNVIDIA:mainfrom
mihai-chiorean:fix/logs-command
Closed

fix(cli): use correct openshell logs subcommand#267
mihai-chiorean wants to merge 1 commit intoNVIDIA:mainfrom
mihai-chiorean:fix/logs-command

Conversation

@mihai-chiorean
Copy link
Copy Markdown

@mihai-chiorean mihai-chiorean commented Mar 18, 2026

Summary

  • nemoclaw <name> logs calls openshell sandbox logs which doesn't exist as a subcommand
  • The correct command is openshell logs <name> (top-level, not under sandbox)
  • Also fixes the follow flag from --follow to --tail to match openshell's interface

Fixes #253

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the logs command to invoke the proper subcommand, ensuring log retrieval works as expected.
    • Preserved and clarified the "follow" behavior: continuous log streaming now correctly maps to the tail-style flag so real-time log follow functions reliably.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f06181d-5ec7-433c-8f4c-93c3647dcfd5

📥 Commits

Reviewing files that changed from the base of the PR and between 0bee465 and 79e3fc7.

📒 Files selected for processing (1)
  • bin/nemoclaw.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • bin/nemoclaw.js

📝 Walkthrough

Walkthrough

Replaces the OpenShell subcommand used for sandbox logs from openshell sandbox logs to openshell logs, and maps the follow option into a --tail flag for the invoked command. Adds an inline comment documenting the corrected subcommand.

Changes

Cohort / File(s) Summary
CLI Command Fix
bin/nemoclaw.js
Changed sandbox logs invocation from openshell sandbox logs to openshell logs; convert follow into --tail; added an inline comment noting the corrected subcommand.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ericksoa

Poem

🐰 I hopped the CLI to fix the logs’ song,
Swapped sandbox away, where it didn't belong.
With openshell logs and a friendly --tail,
The output flows steady down the debug trail. 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: fixing the CLI to use the correct openshell logs subcommand instead of the incorrect sandbox logs variant.
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #253: it changes the invocation from 'openshell sandbox logs' to 'openshell logs', updates the flag from --follow to --tail, and eliminates the runtime error.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the logs command issue. The single-line modification to bin/nemoclaw.js with an inline comment is focused and contains no extraneous changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added NemoClaw CLI Use this label to identify issues with the NemoClaw command-line interface (CLI). observability Use this label to improve NemoClaw logging, metrics, and tracing. labels Mar 18, 2026
openshell does not have a 'sandbox logs' subcommand. The correct
command is 'openshell logs <name>'. Also fixes the follow flag
from --follow to --tail to match openshell's interface.
@mihai-chiorean
Copy link
Copy Markdown
Author

Closing as duplicate — upstream merged the identical fix in 8b924dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NemoClaw CLI Use this label to identify issues with the NemoClaw command-line interface (CLI). observability Use this label to improve NemoClaw logging, metrics, and tracing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unrecognized subcommand 'logs'

2 participants