Skip to content

fix: use openshell logs instead of nonexistent sandbox logs (#424)#436

Merged
ericksoa merged 1 commit intoNVIDIA:mainfrom
paritoshd-nv:fix/sandbox-logs-command
Mar 19, 2026
Merged

fix: use openshell logs instead of nonexistent sandbox logs (#424)#436
ericksoa merged 1 commit intoNVIDIA:mainfrom
paritoshd-nv:fix/sandbox-logs-command

Conversation

@paritoshd-nv
Copy link
Copy Markdown
Contributor

@paritoshd-nv paritoshd-nv commented Mar 19, 2026

openshell sandbox logs does not exist; the correct command is the openshell logs. Also fixes the follow flag from --follow to --tail to match the openshell CLI.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the logs command implementation to use the correct OpenShell CLI subcommand interface and argument format. The user-facing --follow flag behavior remains unchanged.

`openshell sandbox logs` does not exist; the correct command is the
`openshell logs`. Also fixes the follow flag from --follow to --tail
to match the openshell CLI.

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ba2f4fd9-abdd-4c75-b28f-f8d5b034994f

📥 Commits

Reviewing files that changed from the base of the PR and between bf0642c and 20424fe.

📒 Files selected for processing (1)
  • bin/nemoclaw.js

📝 Walkthrough

Walkthrough

Updated the sandbox log subcommand in the CLI tool to use --tail instead of --follow and changed the invoked OpenShell subcommand path from sandbox logs to logs. The argument parsing interface remains unchanged.

Changes

Cohort / File(s) Summary
CLI Sandbox Log Command
bin/nemoclaw.js
Modified the sandbox log subcommand to replace --follow flag with --tail and updated the OpenShell CLI invocation from openshell sandbox logs to openshell logs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through the logs with glee,
--tail now wags where --follow used to be,
sandbox logs became just logs so neat,
Small changes make the CLI dance complete!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and concisely describes the main change: replacing a non-existent openshell sandbox logs command with the correct openshell logs command. This directly matches the changeset modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

Copy link
Copy Markdown
Contributor

@ericksoa ericksoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested thoroughly — 14/14 tests pass. Correct use of openshell logs command. Clean and minimal fix.

@ericksoa ericksoa merged commit 8b924dd into NVIDIA:main Mar 19, 2026
4 checks passed
Ryuketsukami pushed a commit to Ryuketsukami/NemoClaw that referenced this pull request Mar 24, 2026
…) (NVIDIA#436)

`openshell sandbox logs` does not exist; the correct command is the
`openshell logs`. Also fixes the follow flag from --follow to --tail
to match the openshell CLI.

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
jessesanford pushed a commit to jessesanford/NemoClaw that referenced this pull request Mar 24, 2026
…) (NVIDIA#436)

`openshell sandbox logs` does not exist; the correct command is the
`openshell logs`. Also fixes the follow flag from --follow to --tail
to match the openshell CLI.

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants