docs(readme): add macOS/Apple Silicon as supported platform#359
docs(readme): add macOS/Apple Silicon as supported platform#359webdevpraveen wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Relates to NVIDIA#260 The Prerequisites section listed only Linux Ubuntu 22.04 LTS, leaving macOS/Apple Silicon users with no guidance despite NemoClaw working on macOS with Docker Desktop (confirmed in issue NVIDIA#260 by multiple contributors on M-series Macs). Add macOS 13+ with Docker Desktop as an explicitly supported platform in the Software prerequisites. Signed-off-by: webdevpraveen <pr4veensingh@proton.me>
📝 WalkthroughWalkthroughAdded a macOS 13 (Ventura) or later requirement with Docker Desktop to the Software prerequisites section in README.md. Single-line documentation update with no functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 49: The macOS prerequisite row in the README table is using list syntax
which breaks rendering; replace the bulleted line with a proper table row entry
matching the other rows' format: remove the leading "*" and format the cell
content as plain text (e.g., "macOS 13 (Ventura) or later — Docker Desktop
installed and running" or the same two-column table style used elsewhere) so the
row renders correctly in the Markdown table.
| | Dependency | Version | | ||
| |------------|----------------------------------| | ||
| | Linux | Ubuntu 22.04 LTS or later | | ||
| * macOS 13 (Ventura) or later with [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running |
There was a problem hiding this comment.
Fix Markdown table formatting for macOS prerequisite.
Line 49 uses list syntax inside a table, which breaks the table rendering. Keep this as a table row like the other dependencies.
✅ Proposed fix
-* macOS 13 (Ventura) or later with [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running
+| macOS | 13 (Ventura) or later with [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * macOS 13 (Ventura) or later with [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running | |
| | macOS | 13 (Ventura) or later with [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 49, The macOS prerequisite row in the README table is
using list syntax which breaks rendering; replace the bulleted line with a
proper table row entry matching the other rows' format: remove the leading "*"
and format the cell content as plain text (e.g., "macOS 13 (Ventura) or later —
Docker Desktop installed and running" or the same two-column table style used
elsewhere) so the row renders correctly in the Markdown table.
wscurran
added
Platform: macOS
…#366) * feat(policy): support host wildcards and multi-port endpoints Add glob-style host wildcards to endpoints[].host using OPA's glob.match with "." as delimiter — *.example.com matches a single DNS label, **.example.com matches across labels. Validation rejects bare * and requires *. prefix; warns on broad patterns like *.com. Add repeated uint32 ports field to NetworkEndpoint for multi-port support. Backwards compatible: existing port scalar is normalized to ports array. Both the proto-to-JSON and YAML-to-JSON conversion paths emit a ports array; Rego always references endpoint.ports[_]. Fix OpaEngine::reload() to route through the full preprocessing pipeline instead of bypassing L7 validation and port normalization. Closes NVIDIA#359 * fix(policy): reject configs with both port and ports set --------- Co-authored-by: johntmyers <johntmyers@users.noreply.github.com>
|
Thanks for flagging this — macOS/Apple Silicon documentation was definitely a gap at the time. This has since been addressed in #925, which added macOS first-run prerequisites to the quick start guide. Closing as covered. |
2 participants
Summary
Relates to #260
The Prerequisites section in
README.mdonly listsLinux Ubuntu 22.04 LTSunder Software requirements. This leaves macOS/Apple Silicon users with no guidance, despite NemoClaw working on macOS with Docker Desktop — confirmed in #260 by multiple contributors on M-series Macs.Change
Add macOS 13 (Ventura) or later with Docker Desktop as an explicitly supported platform in the Software prerequisites section.
Context from issue #260
The following features are confirmed working on macOS/Apple Silicon:
Not documenting macOS support causes confusion for Mac users who assume NemoClaw is Linux-only.
Docs-only change. Zero logic changes.
Summary by CodeRabbit