Skip to content

Fix install wording#366

Closed
jacobtomlinson wants to merge 1 commit intoNVIDIA:mainfrom
jacobtomlinson:doc/fresh-wording
Closed

Fix install wording#366
jacobtomlinson wants to merge 1 commit intoNVIDIA:mainfrom
jacobtomlinson:doc/fresh-wording

Conversation

@jacobtomlinson
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson commented Mar 18, 2026

There has been some confusion about this wording to changing requires => creates

Summary by CodeRabbit

  • Documentation
    • Updated Quick Start and getting started documentation to clarify that NemoClaw creates a fresh installation of OpenClaw.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c50b9998-96c6-41b8-9fa8-b2022065ac29

📥 Commits

Reviewing files that changed from the base of the PR and between 1897b90 and fd7f5d4.

📒 Files selected for processing (2)
  • README.md
  • docs/get-started/quickstart.md

📝 Walkthrough

Walkthrough

This change updates documentation across two files to reflect that NemoClaw "creates" rather than "requires" a fresh OpenClaw installation, adjusting the description of the action without altering guidance or functionality.

Changes

Cohort / File(s) Summary
Documentation Wording Updates
README.md, docs/get-started/quickstart.md
Changed description from NemoClaw "requires a fresh installation of OpenClaw" to "creates a fresh installation of OpenClaw"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A word, a tweak, a subtle shift,
From "needs" to "makes"—a verbal gift!
The docs now shine with clearer sight,
As NemoClaw creates things right. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix install wording' accurately reflects the main change - correcting documentation wording from 'requires' to 'creates' regarding NemoClaw's installation behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

@wscurran wscurran added the documentation Improvements or additions to documentation label Mar 19, 2026
@jacobtomlinson
Copy link
Copy Markdown
Member Author

Superseded by #370

mafueee pushed a commit to mafueee/NemoClaw that referenced this pull request Mar 28, 2026
…#366)

* feat(policy): support host wildcards and multi-port endpoints

Add glob-style host wildcards to endpoints[].host using OPA's
glob.match with "." as delimiter — *.example.com matches a single
DNS label, **.example.com matches across labels. Validation rejects
bare * and requires *. prefix; warns on broad patterns like *.com.

Add repeated uint32 ports field to NetworkEndpoint for multi-port
support. Backwards compatible: existing port scalar is normalized to
ports array. Both the proto-to-JSON and YAML-to-JSON conversion paths
emit a ports array; Rego always references endpoint.ports[_].

Fix OpaEngine::reload() to route through the full preprocessing
pipeline instead of bypassing L7 validation and port normalization.

Closes NVIDIA#359

* fix(policy): reject configs with both port and ports set

---------

Co-authored-by: johntmyers <johntmyers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants