Bootstrap sandbox OpenClaw config after launch and migrate#5
Closed
Bootstrap sandbox OpenClaw config after launch and migrate#5
Conversation
Signed-off-by: Vincent Koc <vincentkoc@ieee.org>
Signed-off-by: Vincent Koc <vincentkoc@ieee.org>
Signed-off-by: Vincent Koc <vincentkoc@ieee.org>
Signed-off-by: Vincent Koc <vincentkoc@ieee.org>
Signed-off-by: Vincent Koc <vincentkoc@ieee.org>
(cherry picked from commit 0662c8cc12ca42c6791a771be5d3e5f4fe14bbd9)
Signed-off-by: Vincent Koc <vincentkoc@ieee.org>
Contributor
|
Thanks for enhancing the sandbox setup process by running |
wscurran
added
enhancement: feature
Contributor
|
Hey @ericksoa, wanted to touch base on this PR as well. I see you've been active with several contributions and we really appreciate that. The codebase has changed quite a bit since this was opened — we've landed CI checks and a number of new features that may affect the sandbox bootstrap flow. When you have a moment, a rebase onto main would help us review this with the current state of things in mind. No rush, just whenever you get a chance! |
jessesanford
pushed a commit
to jessesanford/NemoClaw
that referenced
this pull request
Mar 24, 2026
…migrate-hooks Fix NemoClaw migrate state sync for hooks and local assets
jyaunches
pushed a commit
to jyaunches/NemoClaw
that referenced
this pull request
Apr 14, 2026
- Guard runArgv/runArgvCapture against shell:true to prevent security bypass (finding NVIDIA#1) — throws if a caller attempts to re-enable shell interpretation. Added 2 tests. - Document the intentional bash -c exception in getOllamaWarmupCommand explaining why it's safe (finding NVIDIA#2). - Remove dead getOpenshellCommand() from policies.ts (finding NVIDIA#3). - Remove unused shellQuote import from nim.ts (finding NVIDIA#4). - Fix brittle indexOf assertion in onboard-readiness test (finding NVIDIA#5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from NVIDIA/openshell-openclaw-plugin#12 by @vincentkoc
Summary
openclaw setupinside the sandbox after a freshlaunchso NemoClaw createsopenclaw.json, the default workspace, and session directories before first usemigratecopies host state so config-less installs still get a valid sandbox configopenshellharness that proves the bootstrap path invokesopenclaw setupand materializesopenclaw.jsonTesting
cd nemoclaw && npm installcd nemoclaw && npm run buildcd nemoclaw && npx eslint src/commands/launch.ts src/commands/migrate.ts src/commands/sandbox-bootstrap.tsdocker build -f test/Dockerfile.sandbox -t nemoclaw-e2e .docker run --rm -v "$PWD/test/e2e-test.sh:/tmp/e2e-test.sh:ro" nemoclaw-e2e /tmp/e2e-test.sh