fix: make onboard robust when rerun after a failed install#84
Closed
WuKongAI-CMU wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix: make onboard robust when rerun after a failed install#84WuKongAI-CMU wants to merge 1 commit intoNVIDIA:mainfrom
WuKongAI-CMU wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
When a previous onboard attempt failed partway through, the sandbox could exist in OpenShell but not in the local registry (or vice versa). Rerunning onboard would then either try to create a duplicate sandbox (failing) or miss the existing one entirely, requiring `uninstall.sh` as a workaround. Now `createSandbox()` checks both the local registry and the actual OpenShell state. When they are out of sync: - The user sees which side has the sandbox (e.g. "found in OpenShell but not registered") - Choosing to keep it re-syncs the registry automatically - Choosing to recreate cleans up both sides before proceeding Closes NVIDIA#23 Signed-off-by: peteryuqin <peter.yuqin@gmail.com>
wscurran
added
bug
Contributor
|
Thanks for fixing the onboard process and ensuring that it handles reruns gracefully, this will definitely improve the user experience for users who encounter installation issues. |
wscurran
added
Getting Started
Contributor
|
This PR has gotten stale. The issue seems addressed as part of #229. |
mafueee
pushed a commit
to mafueee/NemoClaw
that referenced
this pull request
Mar 28, 2026
…andbox containers (NVIDIA#84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23 —
nemoclaw onboardnow handles reruns gracefully without requiringuninstall.sh.Root cause: After a failed onboard, the sandbox could exist in OpenShell but not in the local registry (or vice versa). The code only checked the registry, so it either tried to create a duplicate or missed the orphan entirely.
Fix:
createSandbox()now checks both the registry and OpenShell:Test plan
nemoclaw onboard, kill during sandbox creation, rerun → should detect orphan and offer to recreate or keepnemoclaw onboardafter successful install → should detect existing sandbox and offer to reconfigure🤖 Generated with Claude Code