Skip to content

fix: make onboard robust when rerun after a failed install #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WuKongAI-CMU wants to merge 1 commit into from
Closed

fix: make onboard robust when rerun after a failed install #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions bin/lib/onboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,32 @@ async function createSandbox(gpu) {
const nameAnswer = await prompt(" Sandbox name [my-assistant]: ");
const sandboxName = nameAnswer || "my-assistant";

// Check if sandbox already exists in registry
const existing = registry.getSandbox(sandboxName);
if (existing) {
const recreate = await prompt(` Sandbox '${sandboxName}' already exists. Recreate? [y/N]: `);
// Check if sandbox already exists — look at both the registry and the
// actual OpenShell state. A previous failed onboard may have created a
// sandbox in OpenShell without registering it (see #22), or vice-versa.
const existsInRegistry = !!registry.getSandbox(sandboxName);
const existsInOpenshell = !!runCapture(
`openshell sandbox status ${sandboxName} --json 2>/dev/null`,
{ ignoreError: true }
);

if (existsInRegistry || existsInOpenshell) {
const where = existsInRegistry && existsInOpenshell
? "registered and running"
: existsInRegistry
? "registered (but not found in OpenShell)"
: "found in OpenShell (but not registered)";
const recreate = await prompt(` Sandbox '${sandboxName}' already exists (${where}). Recreate? [y/N]: `);
if (recreate.toLowerCase() !== "y") {
console.log(" Keeping existing sandbox.");
// Sync: if it exists in OpenShell but not in the registry, register it
if (existsInOpenshell && !existsInRegistry) {
registry.registerSandbox({ name: sandboxName, gpuEnabled: !!gpu });
console.log(` ✓ Re-registered '${sandboxName}' in local registry.`);
}
return sandboxName;
}
// Destroy old sandbox
// Clean up both sides before recreating
run(`openshell sandbox delete ${sandboxName} 2>/dev/null || true`, { ignoreError: true });
registry.removeSandbox(sandboxName);
}
Expand Down