Fix DAct input ordering of gradient input and activation input#1460
Closed
jberchtold-nvidia wants to merge 2 commits intoNVIDIA:release_v2.0from
Closed
Fix DAct input ordering of gradient input and activation input#1460jberchtold-nvidia wants to merge 2 commits intoNVIDIA:release_v2.0from
jberchtold-nvidia wants to merge 2 commits intoNVIDIA:release_v2.0from
Conversation
Collaborator
Author
|
/te-ci |
Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
652e986 to
42f3560
Compare
Collaborator
Author
|
/te-ci |
14 tasks
Member
|
Fixed in #1462, which was just merged. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where nvte_quantize_dbias_ and
cast_fp8_2Dwhere the gradient input and activation inputs were incorrectly swapped in their usages.Type of change
Changes
Please list the changes introduced in this PR:
dact_fnin activation_template.h to undo the swapping of parameterscast_fp8_2D_kernelto fix usages of input and act_input tensors to correctly usage input as the gradient and act_input as the original activation input from the forward passChecklist: