[PyTorch] Enable quantized activation backward kernels in operation-based API tests#1463
Closed
timmoon10 wants to merge 4 commits intoNVIDIA:mainfrom
Closed
[PyTorch] Enable quantized activation backward kernels in operation-based API tests#1463timmoon10 wants to merge 4 commits intoNVIDIA:mainfrom
timmoon10 wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
cb9701c to
1470ed8
Compare
…ests Signed-off-by: Tim Moon <tmoon@nvidia.com>
1470ed8 to
2d936dc
Compare
Collaborator
Author
|
/te-ci pytorch |
Collaborator
Author
|
/te-ci pytorch |
Collaborator
Author
|
/te-ci pytorch |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1462 and #1460 are attempting to fix a correctness bug in the FP8 and MXFP8 backward activation kernels. This PR modifies the operation-based API tests (
test_fusible_ops.py) so that they includes these kernels. These tests have tighter tolerances than the module tests (e.g.test_numerics.py), so they would have caught this bug.Type of change
Changes
Checklist: