Skip to content

[PyTorch] Explicitly specify quantized tensor usages needed for linear op backward#1646

Merged
timmoon10 merged 1 commit intoNVIDIA:mainfrom
timmoon10:debug-te-sequential-usages
Apr 9, 2025
Merged

[PyTorch] Explicitly specify quantized tensor usages needed for linear op backward#1646
timmoon10 merged 1 commit intoNVIDIA:mainfrom
timmoon10:debug-te-sequential-usages

Conversation

@timmoon10
Copy link
Collaborator

Description

I've experienced some failures with te.Sequential when the linear op recieves quantized tensors without the required usages. This PR is a quick bugfix that explicity specifies the required usages for the dgrad and wgrad GEMMs.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added the bug Something isn't working label Apr 4, 2025
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10 timmoon10 merged commit 20e95ba into NVIDIA:main Apr 9, 2025
20 of 23 checks passed
wdykas pushed a commit to wdykas/TransformerEngine that referenced this pull request Apr 14, 2025
…r op backward (NVIDIA#1646)

Explicitly specify quantized tensor usages needed for linear op backward

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Peter Dykas <wdykas@nvidia.com>
@timmoon10 timmoon10 deleted the debug-te-sequential-usages branch May 22, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant