Avoid amax roll for non-run modules#825
Merged
ksivaman merged 1 commit intoNVIDIA:mainfrom Apr 30, 2024
Merged
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Member
Author
|
/te-ci pytorch |
cyanguwa
approved these changes
Apr 30, 2024
ptrendx
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
11 tasks
Collaborator
|
This fixes the bug discussed in #786 (review). Previously, if the amax history length didn't match the number of grad accumulation steps, the FP8 scaling factors could change in a step where the FP8 data does not change. |
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The amax history should be rolled only for modules which ran and thus produced a non-zero amax. This bug was introduced in #575.
Fixes #814
Type of change