[PyTorch] Update FP8 recipe test to handle recipe changes#834
Merged
timmoon10 merged 1 commit intoNVIDIA:mainfrom May 7, 2024
Merged
[PyTorch] Update FP8 recipe test to handle recipe changes#834timmoon10 merged 1 commit intoNVIDIA:mainfrom
timmoon10 merged 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
force-pushed
the
fp8-recipe-test-bugfix
branch
from
da50aa4 to
d90ee8e
Compare
Collaborator
Author
|
/te-ci pytorch |
ksivaman
reviewed
May 6, 2024
| ref_scale_inv_forward = torch.reciprocal(ref_scale_forward) | ||
| update_weight_scale_inv = is_first_microbatch is None or is_first_microbatch | ||
| if not update_weight_scale_inv: | ||
| update_weight_amax = is_first_microbatch is None or is_first_microbatch |
Member
There was a problem hiding this comment.
For our current setup, this should always be True right?
Collaborator
Author
There was a problem hiding this comment.
The FP8 cast kernel is never called on the weights with is_first_microbatch=False, so the amax is left at zero. #825 changes the FP8 scale update kernel so that it doesn't roll the amax history or update the scales if the amax is zero.
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
Update FP8 recipe test to handle recipe changes Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes CI failures in the FP8 recipe test, which did not reflect recent changes in #575 and #825.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: