fix(ci): make GPU training and inference symmetric#579
Open
yuanchen8911 wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(ci): make GPU training and inference symmetric#579yuanchen8911 wants to merge 1 commit intoNVIDIA:mainfrom
yuanchen8911 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
61e2e09 to
c78e996
Compare
25 tasks
c78e996 to
4085ee2
Compare
4085ee2 to
81349f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency: This PR depends on #577. It is opened against
mainlike #577, so GitHub will show the #577 dedup changes in the diff until #577 merges.Make the H100 training and inference GPU workflows symmetric, and fix the PR #579 E2E/tooling regression by pinning GoReleaser and aligning the repo toolchain to Go
1.26.2.Motivation / Context
This is the follow-up to the GPU conformance dedup work in #577.
It removes the remaining drift between training and inference GPU CI so both workflows exercise the same core conformance checks, with only controller/gateway coverage and the inference smoke-test tail differing.
It also fixes the PR #579 E2E failure where
tools/setup-toolsinstalled GoReleaser viago install ...@latest, which drifted tov2.15.3and required Go1.26.2while CI was still on Go1.26.1.Fixes: N/A
Related: #554, #577
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
recipes/overlays/h100-kind-training-kubeflow.yamland updates the training workflow to installplatform: kubeflow.robust-controllerandsecure-accelerator-access, and adds Kubeflow chainsaw/assert coverage for the trainer controller, webhook, andTrainJobCRD.H100 x2, addsgang-schedulingto the kind inference recipes, and removes deaddeploymentphase plumbing from the inference workflow.v2.15.3in.settings.yaml, threads that exact version throughtools/setup-toolsand allgoreleaser-actioncall sites, and bumps the repo Go version references to1.26.2.goreleaser_versioninputs so callers cannot drift from.settings.yaml, update stale docs that still mention older GoReleaser versions, remove the orphanedtests/chainsaw/ai-conformance/kind-training/directory, and consider pinning the macOSbrew install goreleaserpath intools/setup-tools.Testing
unset GITLAB_TOKEN make qualifymake qualifypassedtest-coverage,lint, ande2elocally.make qualifyfailed only atscanlocally becausegrype dir:.picked up a stale repo-root./aicrbinary built withgo1.26.1; the freshly rebuiltdist/aicr_darwin_arm64_v8.0/aicrisgo1.26.2.Risk Assessment
Rollout notes: This changes the inference GPU job to require
H100 x2, assumes the corresponding runner class remains available, and pins release/build tooling to GoReleaserv2.15.3. Merge this after #577.Checklist
make testwith-race)make lint)git commit -S) — GPG signing info