fix(ci): pin e2e goreleaser and exclude local build artifacts#580
Merged
yuanchen8911 merged 1 commit intoNVIDIA:mainfrom Apr 15, 2026
Merged
fix(ci): pin e2e goreleaser and exclude local build artifacts#580yuanchen8911 merged 1 commit intoNVIDIA:mainfrom
yuanchen8911 merged 1 commit intoNVIDIA:mainfrom
Conversation
|
🌿 Preview your docs: https://nvidia-preview-codex-grype-scan-fix.docs.buildwithfern.com/aicr |
9ae18a2 to
0cb8692
Compare
bead7e7 to
9b43855
Compare
9b43855 to
97fe272
Compare
dims
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the Linux E2E GoReleaser install path so qualification does not drift with upstream releases, and exclude generated local build artifacts from
make scan.Motivation / Context
make scanrunsgrype dir:., and Grype scans files on disk rather than honoring.gitignore. That means stale locally built binaries can trigger false-positive stdlib findings during local scans.Separately, the Linux E2E path still installed GoReleaser via an unpinned
@latestpath throughtools/setup-tools, which can break qualification when a new GoReleaser release raises its Go requirement before CI has moved.Fixes: N/A
Related: #579
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
./aicr,./aicrd,./bin/**, and./dist/**to.grype.yamlexclusions so local scans ignore generated binaries and release output.docs/contributor/cli.mdprofiling examples to buildbin/aicrinstead of./aicr..settings.yamlto Go1.26.2and GoReleaserv2.15.3so the qualification path uses compatible pinned versions.tools/setup-toolstogo install github.com/goreleaser/goreleaser/v2@${GORELEASER_VERSION}.goreleaser_versioninto thecli-e2eaction fromqualification.yamlso attested CLI builds do not float on@latest.Testing
make scanpassed locally with stale./aicrand./bin/aicrbinaries present.git diff --check origin/main...HEADpassed.make qualifyin this sandbox; CI is the right signal for the E2E path.Risk Assessment
Rollout notes: This keeps PR #580 limited to the local scan fix plus the minimal qualification-path pin needed to stop the known Linux E2E drift.
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info