Update raft headers by aamijar · Pull Request #865 · NVIDIA/cuopt

aamijar · 2026-02-13T17:22:23Z

Testing with rapidsai/raft#2939 and adding fixes.

Summary by CodeRabbit

Chores
- Unified include paths for RAFT NVTX and cuSPARSE headers across the codebase.
- Bumped header copyright years to 2026.
Tests
- Updated test files to use the new RAFT header paths.

coderabbitai · 2026-02-13T17:24:50Z

📝 Walkthrough

Walkthrough

RAFT retrieval in CMake switched to fork aamijar with pinned tag raft-deprecated-headers. Many source, test, and benchmark files updated RAFT include paths from raft/common or raft/sparse/detail to raft/core headers; copyright years bumped where applicable.

Changes

Cohort / File(s)	Summary
CMake: RAFT retrieval `cpp/cmake/thirdparty/get_raft.cmake`	Changed `find_and_configure_raft()` args: `FORK` → `aamijar`, `PINNED_TAG` → `raft-deprecated-headers`; updated header copyright year.
NVTX include updates (many sources/tests/benchmarks) `cpp/.../branch_and_bound/.cpp`, `cpp/.../dual_simplex/.cpp`, `cpp/.../pdlp/*/.cu`, `cpp/.../mip_heuristics/*/.cu`, `cpp/src/barrier/barrier.cu`, `cpp/src/.../solution_writer.cu`, `cpp/src/.../cython.cu`, `cpp/src/routing/.../.hpp`, `benchmarks/.../benchmark_helper.hpp`	Replaced `#include <raft/common/nvtx.hpp>` with `#include <raft/core/nvtx.hpp>` across multiple files (single-line include edits).
cuSPARSE macro include updates `cpp/.../pdlp/.cu`, `cpp/.../mip_heuristics/.cu`, `cpp/src/barrier/cusparse_view.`, `cpp/src/pdlp/cusparse_view.`, `cpp/tests/.../*.cu`, `benchmarks/.../run_pdlp.cu`	Replaced `#include <raft/sparse/detail/cusparse_macros.h>` with `#include <raft/core/cusparse_macros.hpp>` in CUDA/C++ sources and tests.
Tests & benchmarks `cpp/tests/dual_simplex/unit_tests/solve_barrier.cu`, `cpp/tests/linear_programming/pdlp_test.cu`, `benchmarks/linear_programming/cuopt/benchmark_helper.hpp`, `benchmarks/.../run_pdlp.cu`	Updated test and benchmark includes to use RAFT `core` headers to match source changes.
Copyright/year bumps `cpp/src/routing/.../eax_recombiner.hpp`, `cpp/src/routing/local_search/.../move_candidates.cuh`, `cpp/tests/...`	Minor copyright year updates (e.g., 2025 → 2025-2026 or 2026).
Miscellaneous single-line edits numerous `cpp/src/...` files (grouped above)	Mostly one-line include path adjustments; no logic, API, or behavior changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`
Title check	✅ Passed	The pull request title 'Update raft headers' accurately summarizes the main change: updating RAFT library header include paths across multiple files from deprecated locations to new core paths.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@cpp/cmake/thirdparty/get_raft.cmake`:
- Around line 41-44: The diff introduces a personal fork and a moving branch:
update the find_and_configure_raft invocation to remove the personal fork
reference by replacing FORK aamijar with FORK rapidsai (or omit FORK to default
to rapidsai) and replace the branch PINNED_TAG raft-deprecated-headers with a
deterministic pin (either ${rapids-cmake-checkout-tag} or an explicit commit
SHA) so find_and_configure_raft uses the official rapidsai repo and a fixed
commit/ tag for reproducible builds.

cpp/cmake/thirdparty/get_raft.cmake

hlinsen

Lgtm. Let's wait for: rapidsai/raft#2939 before merging

aamijar · 2026-02-14T00:29:22Z

Lgtm. Let's wait for: rapidsai/raft#2939 before merging

We should merge this one before rapidsai/raft#2939 to avoid breaking cuopt.
Let's let this CI run finish to make sure it works with rapidsai/raft#2939, then I will revert the cmake raft pin and let CI run again.

anandhkb · 2026-02-18T17:59:23Z

/merge

Depends on rapidsai/cuvs#1763. Resolves #2937 This PR does the following: 1. Removes files with the following message ```cpp #ifndef RAFT_HIDE_DEPRECATION_WARNINGS #pragma message(__FILE__ \ " is deprecated and will be removed in a future release." \ " Please use the raft/sparse/solver version instead.") #endif ``` 2. Removes files with the following message ```cpp /** * This file is deprecated and will be removed in a future release. */ ``` 3. Pulls from correct non-deprecated headers like using`raft/util/cudart_utils.cuh` instead of `raft/core/cudart_utils.cuh` 4. Pulls correct functionality from non-deprecated headers like using `raft/linalg/matrix_vector.cuh` instead of `raft/matrix/math.cuh`. This requires using the newer mdspan based apis. 5. Consolidates `gemm.cuh` and `gemm.hpp` into just `gemm.cuh` **Update:** There were a couple of fixes included in this PR that I have decoupled. Instead those fixes should be merged in #2940. This will allow us to unravel the merging sequence better to avoid breaking changes altogether. Still marking this PR as breaking for awareness purposes. After merging #2940, the cuml side and cuvs side can be updated to use the non-deprecated apis. Then we can merge this raft PR to remove the deprecated and unused headers. **Update:** There are a couple of breaking changes that affect cugraph and cuopt, so we will need to merge fixes for those first. **Merging sequence:** #2940 -> rapidsai/cuvs#1763 -> rapidsai/cuml#7752 -> rapidsai/cuml#7797 -> rapidsai/cugraph#5429 -> NVIDIA/cuopt#865 -> #2939 **Downstream libraries CI status:** cuvs: 🟢 cuml: 🟢 cugraph: 🟢 cuopt: 🟢 Authors: - Anupam (https://github.com/aamijar) Approvers: - Bradley Dice (https://github.com/bdice) - Divye Gala (https://github.com/divyegala) - Dante Gama Dessavre (https://github.com/dantegd) URL: #2939

aamijar requested review from a team as code owners February 13, 2026 17:22

aamijar requested review from Iroy30 and bdice February 13, 2026 17:22

ci-test-raft

23287ab

coderabbitai bot reviewed Feb 13, 2026

View reviewed changes

cpp/cmake/thirdparty/get_raft.cmake Show resolved Hide resolved

aamijar requested a review from a team as a code owner February 13, 2026 23:35

aamijar requested review from chris-maes and nguidotti February 13, 2026 23:35

aamijar commented Feb 13, 2026

View reviewed changes

cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved

aamijar added 2 commits February 13, 2026 23:37

fix raft headers

71f66f2

fix style

b845aab

aamijar changed the title ~~Test CI with raft #2939~~ Update raft headers Feb 14, 2026

hlinsen approved these changes Feb 14, 2026

View reviewed changes

aamijar mentioned this pull request Feb 14, 2026

Remove deprecated headers rapidsai/raft#2939

Merged

unpin raft

cfb8bbb

anandhkb added the breaking Introduces a breaking change label Feb 17, 2026

anandhkb added this to the 26.04 milestone Feb 17, 2026

anandhkb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change and removed breaking Introduces a breaking change labels Feb 17, 2026

rapids-bot bot merged commit ab7edbf into NVIDIA:main Feb 18, 2026
187 of 189 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update raft headers#865

Update raft headers#865
rapids-bot[bot] merged 4 commits intoNVIDIA:mainfrom
aamijar:ci-test-raft

aamijar commented Feb 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

hlinsen left a comment

Uh oh!

aamijar commented Feb 14, 2026 •

edited

Loading

Uh oh!

anandhkb commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aamijar commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hlinsen left a comment

Choose a reason for hiding this comment

Uh oh!

aamijar commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandhkb commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aamijar commented Feb 13, 2026 •

edited

Loading

coderabbitai bot commented Feb 13, 2026 •

edited

Loading

aamijar commented Feb 14, 2026 •

edited

Loading