Merged
Conversation
Member
Author
|
/merge |
benfred
pushed a commit
to benfred/cuvs
that referenced
this pull request
Feb 10, 2026
Prepares for rapidsai/raft#2939. This PR updates the following headers: | old | new | |-----|-----| | `#include <raft/core/cudart_utils.hpp>` | `#include <raft/util/cudart_utils.hpp>` | | `#include <raft/common/nvtx.hpp>` | `#include <raft/core/nvtx.hpp>` | | `#include <raft/sparse/linalg/masked_matmul.hpp>` | `#include <raft/sparse/linalg/masked_matmul.cuh>` | | `#include <raft/linalg/gemm.hpp>` | `#include <raft/linalg/gemm.cuh>` | | `#include <raft/sparse/mst/mst.cuh>` | `#include <raft/sparse/solver/mst.cuh>` | Authors: - Anupam (https://github.com/aamijar) Approvers: - Jinsol Park (https://github.com/jinsolp) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1763
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Feb 23, 2026
Depends on rapidsai/cuvs#1763. Resolves #2937 This PR does the following: 1. Removes files with the following message ```cpp #ifndef RAFT_HIDE_DEPRECATION_WARNINGS #pragma message(__FILE__ \ " is deprecated and will be removed in a future release." \ " Please use the raft/sparse/solver version instead.") #endif ``` 2. Removes files with the following message ```cpp /** * This file is deprecated and will be removed in a future release. */ ``` 3. Pulls from correct non-deprecated headers like using`raft/util/cudart_utils.cuh` instead of `raft/core/cudart_utils.cuh` 4. Pulls correct functionality from non-deprecated headers like using `raft/linalg/matrix_vector.cuh` instead of `raft/matrix/math.cuh`. This requires using the newer mdspan based apis. 5. Consolidates `gemm.cuh` and `gemm.hpp` into just `gemm.cuh` **Update:** There were a couple of fixes included in this PR that I have decoupled. Instead those fixes should be merged in #2940. This will allow us to unravel the merging sequence better to avoid breaking changes altogether. Still marking this PR as breaking for awareness purposes. After merging #2940, the cuml side and cuvs side can be updated to use the non-deprecated apis. Then we can merge this raft PR to remove the deprecated and unused headers. **Update:** There are a couple of breaking changes that affect cugraph and cuopt, so we will need to merge fixes for those first. **Merging sequence:** #2940 -> rapidsai/cuvs#1763 -> rapidsai/cuml#7752 -> rapidsai/cuml#7797 -> rapidsai/cugraph#5429 -> NVIDIA/cuopt#865 -> #2939 **Downstream libraries CI status:** cuvs: 🟢 cuml: 🟢 cugraph: 🟢 cuopt: 🟢 Authors: - Anupam (https://github.com/aamijar) Approvers: - Bradley Dice (https://github.com/bdice) - Divye Gala (https://github.com/divyegala) - Dante Gama Dessavre (https://github.com/dantegd) URL: #2939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares for rapidsai/raft#2939.
This PR updates the following headers:
#include <raft/core/cudart_utils.hpp>#include <raft/util/cudart_utils.hpp>#include <raft/common/nvtx.hpp>#include <raft/core/nvtx.hpp>#include <raft/sparse/linalg/masked_matmul.hpp>#include <raft/sparse/linalg/masked_matmul.cuh>#include <raft/linalg/gemm.hpp>#include <raft/linalg/gemm.cuh>#include <raft/sparse/mst/mst.cuh>#include <raft/sparse/solver/mst.cuh>