Skip to content

Update raft headers#1763

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:raft-deprecated-headers
Feb 3, 2026
Merged

Update raft headers#1763
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:raft-deprecated-headers

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Feb 3, 2026

Prepares for rapidsai/raft#2939.

This PR updates the following headers:

old new
#include <raft/core/cudart_utils.hpp> #include <raft/util/cudart_utils.hpp>
#include <raft/common/nvtx.hpp> #include <raft/core/nvtx.hpp>
#include <raft/sparse/linalg/masked_matmul.hpp> #include <raft/sparse/linalg/masked_matmul.cuh>
#include <raft/linalg/gemm.hpp> #include <raft/linalg/gemm.cuh>
#include <raft/sparse/mst/mst.cuh> #include <raft/sparse/solver/mst.cuh>

@aamijar aamijar requested a review from a team as a code owner February 3, 2026 07:00
@aamijar aamijar self-assigned this Feb 3, 2026
@aamijar aamijar added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 3, 2026
@aamijar aamijar moved this to In Progress in Unstructured Data Processing Feb 3, 2026
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Feb 3, 2026

/merge

@rapids-bot rapids-bot bot merged commit 3a9228c into rapidsai:main Feb 3, 2026
94 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Unstructured Data Processing Feb 3, 2026
benfred pushed a commit to benfred/cuvs that referenced this pull request Feb 10, 2026
Prepares for rapidsai/raft#2939.

This PR updates the following headers:

| old | new |
|-----|-----|
| `#include <raft/core/cudart_utils.hpp>` | `#include <raft/util/cudart_utils.hpp>` |
| `#include <raft/common/nvtx.hpp>` | `#include <raft/core/nvtx.hpp>` |
| `#include <raft/sparse/linalg/masked_matmul.hpp>` | `#include <raft/sparse/linalg/masked_matmul.cuh>` |
| `#include <raft/linalg/gemm.hpp>` | `#include <raft/linalg/gemm.cuh>` |
| `#include <raft/sparse/mst/mst.cuh>` | `#include <raft/sparse/solver/mst.cuh>` |

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Jinsol Park (https://github.com/jinsolp)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#1763
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Feb 23, 2026
Depends on rapidsai/cuvs#1763. Resolves #2937

This PR does the following:
1. Removes files with the following message
```cpp
#ifndef RAFT_HIDE_DEPRECATION_WARNINGS
#pragma message(__FILE__                                                  \
                " is deprecated and will be removed in a future release." \
                " Please use the raft/sparse/solver version instead.")
#endif
```
2. Removes files with the following message
```cpp
/**
 * This file is deprecated and will be removed in a future release.
 */
```
3. Pulls from correct non-deprecated headers like using`raft/util/cudart_utils.cuh` instead of `raft/core/cudart_utils.cuh`
4. Pulls correct functionality from non-deprecated headers like using `raft/linalg/matrix_vector.cuh` instead of `raft/matrix/math.cuh`. This requires using the newer mdspan based apis.
5. Consolidates `gemm.cuh` and `gemm.hpp` into just `gemm.cuh`

**Update:**
There were a couple of fixes included in this PR that I have decoupled. Instead those fixes should be merged in #2940.
This will allow us to unravel the merging sequence better to avoid breaking changes altogether. Still marking this PR as breaking for awareness purposes.
After merging #2940, the cuml side and cuvs side can be updated to use the non-deprecated apis. Then we can merge this raft PR to remove the deprecated and unused headers.

**Update:**
There are a couple of breaking changes that affect cugraph and cuopt, so we will need to merge fixes for those first.

**Merging sequence:**
#2940 -> rapidsai/cuvs#1763 -> rapidsai/cuml#7752 -> rapidsai/cuml#7797 -> rapidsai/cugraph#5429 -> NVIDIA/cuopt#865 -> #2939

**Downstream libraries CI status:**
cuvs: 🟢
cuml: 🟢
cugraph: 🟢
cuopt: 🟢

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #2939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants