fix(aws): propagate architecture in cluster mode#661
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Feb 13, 2026
Merged
Conversation
Pass Image.Architecture to resolveImageForNode instead of empty string. Previously, cluster mode always defaulted to x86_64 regardless of the user's image architecture specification. Also add documentation for arm64 instance type alternatives in the API type comments. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Pull Request Test Coverage Report for Build 21983837470Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR improves architecture handling in cluster mode by explicitly extracting and passing the architecture from the Image spec to the AMI resolution function. It also adds helpful documentation for arm64 instance type alternatives.
Changes:
- Explicitly extract architecture from Image spec before passing to resolveImageForNode in cluster mode
- Add documentation for arm64 Graviton instance type alternatives (m7g, c7g, g5g families) for both control plane and worker nodes
- Remove duplicate
+optionalkubebuilder markers from InstanceType field comments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/provider/aws/cluster.go | Extract architecture from image spec before calling resolveImageForNode, making the code more explicit about architecture handling |
| api/holodeck/v1alpha1/types.go | Add arm64 instance type documentation and remove duplicate +optional comments from InstanceType fields |
This was referenced Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan