Skip to content

fix(aws): propagate architecture in cluster mode #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArangoGutierrez merged 1 commit into from
Feb 13, 2026
Merged

fix(aws): propagate architecture in cluster mode #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/holodeck/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ type ControlPlaneSpec struct {
Count int32 `json:"count"`

// InstanceType specifies the EC2 instance type for control-plane nodes.
// Default is "m5.xlarge" (x86_64). For arm64, use Graviton types
// (e.g., "m7g.xlarge", "c7g.xlarge").
// +kubebuilder:default="m5.xlarge"
// +optional
// +optional

InstanceType string `json:"instanceType,omitempty"`

// OS specifies the operating system by ID (e.g., "ubuntu-22.04").
Expand Down Expand Up @@ -236,10 +236,10 @@ type WorkerPoolSpec struct {

// InstanceType specifies the EC2 instance type for worker nodes.
// For GPU workloads, use GPU instance types (g4dn, p4d, etc.).
// Default is "g4dn.xlarge" (x86_64). For arm64 GPU workloads,
// use "g5g.xlarge" or similar Graviton GPU instances.
// +kubebuilder:default="g4dn.xlarge"
// +optional
// +optional

InstanceType string `json:"instanceType,omitempty"`

// OS specifies the operating system by ID (e.g., "ubuntu-22.04").
Expand Down
7 changes: 6 additions & 1 deletion pkg/provider/aws/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,12 @@ func (p *Provider) createInstances(
image *v1alpha1.Image,
) ([]InstanceInfo, error) {
// Resolve AMI for this node pool
resolved, err := p.resolveImageForNode(os, image, "")
// Determine architecture from image spec
var arch string
if image != nil && image.Architecture != "" {
arch = image.Architecture
}
resolved, err := p.resolveImageForNode(os, image, arch)
if err != nil {
return nil, fmt.Errorf("error resolving AMI: %w", err)
}
Expand Down
Loading