Skip to content

fix(tests): value conversion and async test #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vchimev merged 1 commit into from
Oct 12, 2017
Merged

fix(tests): value conversion and async test #1035

vchimev merged 1 commit into from
Oct 12, 2017

Conversation

@vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Oct 11, 2017

Tests fixed:

  • Value conversion tests
  • Tests that have done callback should not return a promise. The result is Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

@ghost ghost assigned vakrilov Oct 11, 2017
@ghost ghost added the in progress label Oct 11, 2017
@vchimev vchimev merged commit 3f87f6e into master Oct 12, 2017
@ghost ghost removed the in progress label Oct 12, 2017
@vchimev vchimev deleted the unit-tests-fix branch October 12, 2017 08:01
@vchimev vchimev changed the title fix(tests): Fix tests: value conversion and async test. fix(tests): value conversion and async test Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vchimev vchimev vchimev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vakrilov vakrilov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vakrilov @vchimev