Skip to content

fix(tests): value conversion and async test #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchimev merged 1 commit into from
Oct 12, 2017
Merged

fix(tests): value conversion and async test #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/app/tests/list-view-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ describe("ListView-tests", () => {
});

it("setupItemView is called for every item", (done) => {
return testApp.loadComponent(TestListViewComponent).then((componentRef) => {
testApp.loadComponent(TestListViewComponent).then((componentRef) => {
const component = componentRef.instance;
setTimeout(() => {
assert.equal(component.counter, 3);
Expand All @@ -112,9 +112,9 @@ describe("ListView-tests", () => {


it("itemTemplateSelector selects templates", (done) => {
return testApp.loadComponent(TestListViewSelectorComponent).then((componentRef) => {
testApp.loadComponent(TestListViewSelectorComponent).then((componentRef) => {
setTimeout(() => {
assert.deepEqual(testTemplates, { first: 2, second: 1 });
assert.deepEqual(testTemplates, { first: 2, second: 1 });
done();
}, 1000);
})
Expand Down
2 changes: 1 addition & 1 deletion tests/app/tests/modal-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe("modal-dialog", () => {
let testApp: TestApp = null;

before((done) => {
return TestApp.create([], [ModalComponent, FailComponent, SuccessComponent]).then((app) => {
TestApp.create([], [ModalComponent, FailComponent, SuccessComponent]).then((app) => {
testApp = app;

// HACK: Wait for the navigations from the test runner app
Expand Down
8 changes: 4 additions & 4 deletions tests/app/tests/property-sets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ describe("setting View properties", () => {
it("doesn\'t convert number values", () => {
let view = new TestView();
viewUtil.setProperty(view, "numValue", "42");
assert.strictEqual(42, view.numValue);
assert.strictEqual(<any>"42", view.numValue);

viewUtil.setProperty(view, "numValue", "42.");
assert.strictEqual(42., view.numValue);
assert.strictEqual(<any>"42.", <any>view.numValue);

viewUtil.setProperty(view, "numValue", 0);
assert.strictEqual(0, view.numValue);
Expand All @@ -58,9 +58,9 @@ describe("setting View properties", () => {
it("doesn\'t convert boolean values", () => {
let view = new TestView();
viewUtil.setProperty(view, "boolValue", "true");
assert.strictEqual(true, view.boolValue);
assert.strictEqual(<any>"true", view.boolValue);
viewUtil.setProperty(view, "boolValue", "false");
assert.strictEqual(false, view.boolValue);
assert.strictEqual(<any>"false", view.boolValue);
});

it("sets style values", () => {
Expand Down