fix: unable to work with devices with numeric identifiers #3898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the device identifier contains only numeric symbols or in case it looks like a number (16089e09 for example), CLI fails to work with it. The problem is that CLI thinks an index is passed to it, so it removes "one" from the passed number and tries to find the device on the new index. The other issue is with the `isNumber` helper method which works incorrectly when the string looks like number. Improve the logic in the method and rename it. We cannot parse safely values with exponent (`1e6` for example), but we do not need such functionality. The new method name and tests reflects the described behavior. Before using the identifier as an index, check if we'll find device with the specified identifier.
Fatme
approved these changes
Sep 17, 2018
rosen-vladimirov
deleted the
vladimirov/fix-getting-device-num-identifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the device identifier contains only numeric symbols or in case it looks like a number (16089e09 for example), CLI fails to work with it.
The problem is that CLI thinks an index is passed to it, so it removes "one" from the passed number and tries to find the device on the new index.
The other issue is with the
isNumberhelper method which works incorrectly when the string looks like number. Improve the logic in the method and rename it. We cannot parse safely values with exponent (1e6for example), but we do not need such functionality.The new method name and tests reflects the described behavior.
Before using the identifier as an index, check if we'll find device with the specified identifier.
PR Checklist
What is the current behavior?
When device with numeric identifier is attached, CLI fails to work with it.
What is the new behavior?
CLI can work with devices with numeric identifiers.
Fixes #3832