Skip to content

fix: unable to work with devices with numeric identifiers #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosen-vladimirov merged 2 commits into from
Sep 17, 2018
Merged

fix: unable to work with devices with numeric identifiers #3898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf252c9
fix: unable to work with devices with numeric identifiers
rosen-vladimirov Sep 17, 2018
cb5e390
docs: update Changelog for 4.2.4
rosen-vladimirov Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
NativeScript CLI Changelog
================

4.2.4 (2018, September 17)
4.2.4 (2018, September 19)
==

### Fixed
* [Fixed #3832](https://github.com/NativeScript/nativescript-cli/issues/3832): Unable to work with devices with numeric identifiers
* [Fixed #3881](https://github.com/NativeScript/nativescript-cli/pull/3881): Replace forum references with stack overflow.
* [Fixed #3883](https://github.com/NativeScript/nativescript-cli/issues/3883): CLI installs the app on every change
* [Fixed #3893](https://github.com/NativeScript/nativescript-cli/pull/3893): [API] Errors are raised when emulator lost/found event is raised.
Expand Down
2 changes: 1 addition & 1 deletion lib/common
Open in desktop
Submodule common updated 4 files
+3 −2 helpers.ts
+5 −7 mobile/mobile-core/devices-service.ts
+43 −0 test/unit-tests/helpers.ts
+14 −0 test/unit-tests/mobile/devices-service.ts