The plugin breaks on IOS10

[ignaciolarranaga]

Check out the pull request here with the solution: #41

Best

[timricker]

+1 Can this pull request please be released?

[happygts]

Do you have some news ?

[ignaciolarranaga]

No yet guys, but you can use my fork in the meantime if useful: https://github.com/ignaciolarranaga/push-plugin

[happygts]

Hey,

Any update on the release fix ?

[AntonDobrev]

@ignaciolarranaga Thanks for your contribution. May I please ask, are you building with iOS 10 SDK and Xcode 8? I need to consult this with NativeScript iOS runtime but it appears that the issue appears in the above environment and the fix will not work if the app is built against a lower iOS SDK.

[ignaciolarranaga]

Hi @AntonDobrev, yes I'm with iOS 10 / Xcode 8, and you are correct for lower SDKs it will not work, probably a test to detect which structure has to be used ?

[AntonDobrev]

@ignaciolarranaga Thanks for specifying this.

I commented with the most robust solution (at least on first sight) in the PR. I believe that we should strive to add a more robust solution in the plugin.

[thomasmoon]

@AntonDobrev @ignaciolarranaga

I've just replaced the following reference:
NSNotificationCenter.defaultCenter

To use the ios getter utility:
utils.ios.getter(NSNotificationCenter, NSNotificationCenter.defaultCenter);

And everything is working fine on iOS 8. Should I make a pull request or are you working on this?

Here are my updates:
master...thomasmoon:patch-1

[jaypan]

It would be nice to get this committed.

[Daxito]

+1

[AntonDobrev]

Thanks everyone, I have submitted a PR #54 with the fix similar to the approach suggested by @thomasmoon Let me know should you have questions or considerations.

Awaiting the other contributors to review too.

[AntonDobrev]

Fixed in 0.0.18.