Skip to content
This repository was archived by the owner on Feb 7, 2019. It is now read-only.

Conversation

@ignaciolarranaga
Copy link

Hi guys, some fixes due the last changes of IOS10 I guess.

@thomasmoon
Copy link

Thanks for the fixes @ignaciolarranaga ... I'm using the plugin now from your forked repo now and it builds successfully, though having problems with registration. If this update works it should be integrated into the master asap, cheers!

@AntonDobrev
Copy link
Contributor

@ignaciolarranaga @thomasmoon

Thanks for your input.

After a short discussion with the contributors and the NativeScript runtime team we decided to incorporate a more robust solution in the plugin.

A few details which might be interesting for you.

The solution proposed by Ignacio will work only when the app is built against the iOS 10 SDK. It will not work if the app is built against iOS 9 SDK and vice versa. Since the plugin is officially published in the Telerik Marketplace and npm package, we would like to have it compatible with iOS 9 SDK as well. Having said this, we will consider the following approach:

Using the NS application module methods for adding and removing an observer (more info here) which will ensure the observers are correctly added, independent of the run-time and build-time configurations.

Let me know should you have further questions or considerations.

@ignaciolarranaga
Copy link
Author

Thanks !

@thomasmoon
Copy link

Thanks @AntonDobrev, we have been developing for phones as old as iOS 8, so definitely looking forward to the backwards compatible solution. Any idea when the Nativescript push-plugin will be updated?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants