autogen.sh: Added support of "NOCONFIGURE" environmental variable and code fixes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to code according to shellcheck. Example usage: in RPM spec we do not want to call `./confiogure`, we want to use a special macro, e.g. %configure or %configure2_5x, which will automatically set different flags and options. So, we take a pure git tarball and run: `env NOCONFIGURE=autogen.sh` `%configure2_5x`
mikhailnov
added a commit
to mikhailnov/NetworkManager-pptp
that referenced
this pull request
Oct 13, 2018
…according to shellcheck. This is a port of changes in NetworkManager-openvpn (NetworkManager/NetworkManager-openvpn#3) to NetworkManager-pptp. Example usage: in RPM spec we do not want to call `./confiogure`, we want to use a special macro, e.g. %configure or %configure2_5x, which will automatically set different flags and options. So, we take a pure git tarball and run: `env NOCONFIGURE=autogen.sh` `%configure2_5x` https://abf.io/mikhailnov/networkmanager-openvpn/blob/rosa2016.1/networkmanager-openvpn.spec#lc-63
Member
|
Hi The patch seems wrong to me: runs configure, while doesn't. |
Author
|
Hello, I'm sorry, that was a typo, I've corrected it both here and in #3 |
ecopete
pushed a commit
to ecopete/network-manager-openvpn
that referenced
this pull request
Nov 7, 2019
pids_pending_wait_for_processes() runs the main loop, where queued D-Bus events could be processed. Ensure the plugin is still alive. Fixes the following: nm-openvpn-serv[7900]: g_dbus_method_invocation_take_error: assertion 'error != NULL' failed NetworkManager[4823]: nm-openvpn[7900] <info> openvpn[7912]: send SIGKILL #0 nm_vpn_service_plugin_disconnect (plugin=0x91b8e0, err=err@entry=0x7ffce3dc80c8) at libnm/nm-vpn-service-plugin.c:236 NetworkManager#1 0x00007fe1a361aae6 in impl_vpn_service_plugin_disconnect (plugin=<optimized out>, context=0x92f6c0, user_data=<optimized out>) at libnm/nm-vpn-service-plugin.c:857 NetworkManager#2 0x00007fe1a01b8d1e in ffi_call_unix64 () from target:/lib64/libffi.so.6 NetworkManager#3 0x00007fe1a01b868f in ffi_call () from target:/lib64/libffi.so.6 NetworkManager#4 0x00007fe1a1570f39 in g_cclosure_marshal_generic () from target:/lib64/libgobject-2.0.so.0 NetworkManager#5 0x00007fe1a35f59fe in _nm_dbus_method_meta_marshal (closure=<optimized out>, return_value=0x7ffce3dc84d0, n_param_values=<optimized out>, param_values=<optimized out>, invocation_hint=<optimized out>, marshal_data=<optimized out>) at libnm/nm-dbus-helpers.c:203 #6 0x00007fe1a157073d in g_closure_invoke () from target:/lib64/libgobject-2.0.so.0 #7 0x00007fe1a15834de in signal_emit_unlocked_R () from target:/lib64/libgobject-2.0.so.0 #8 0x00007fe1a158b270 in g_signal_emitv () from target:/lib64/libgobject-2.0.so.0 #9 0x00007fe1a3683034 in _nmdbus_vpn_plugin_skeleton_handle_method_call (connection=<optimized out>, sender=<optimized out>, object_path=<optimized out>, interface_name=0x7fe18c012b80 "org.freedesktop.NetworkManager.VPN.Plugin", method_name=0x7fe18c00f7b0 "Disconnect", parameters=<optimized out>, invocation=0x92f6c0, user_data=0x916e20) at introspection/org.freedesktop.NetworkManager.VPN.Plugin.c:2946 #10 0x00007fe1a18890d7 in g_dbus_interface_method_dispatch_helper () from target:/lib64/libgio-2.0.so.0 #11 0x00007fe1a18713dc in call_in_idle_cb () from target:/lib64/libgio-2.0.so.0 #12 0x00007fe1a1294597 in g_idle_dispatch () from target:/lib64/libglib-2.0.so.0 #13 0x00007fe1a1297bb7 in g_main_context_dispatch () from target:/lib64/libglib-2.0.so.0 #14 0x00007fe1a1297f60 in g_main_context_iterate.isra () from target:/lib64/libglib-2.0.so.0 #15 0x00007fe1a1297fec in g_main_context_iteration () from target:/lib64/libglib-2.0.so.0 #16 0x0000000000403645 in pids_pending_wait_for_processes (main_loop=0x933470) at src/nm-openvpn-service.c:417 https://bugzilla.gnome.org/show_bug.cgi?id=792252
Member
|
Hi. this was forgotten. Also because NetworkManager-openvpn is a GNOME project. It's home is https://gitlab.gnome.org/GNOME/NetworkManager-openvpn The ability to open pull requests on this fork should be disabled, but I think that is not possible with github. Sorry about the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of "NOCONFIGURE" environmental variable.
Fixes to code according to shellcheck.
Example usage:
in RPM spec we do not want to call
./confiogure, we want to usea special macro, e.g. %configure or %configure2_5x,
which will automatically set different flags and options.
So, we take a pure git tarball and run:
env NOCONFIGURE=autogen.sh%configure2_5xhttps://abf.io/mikhailnov/networkmanager-openvpn/blob/rosa2016.1/networkmanager-openvpn.spec#lc-63