feat(ui): unify picker Tab/Enter/Shift+Enter and allow directory attachments#169
Merged
feat(ui): unify picker Tab/Enter/Shift+Enter and allow directory attachments#169
Conversation
7 tasks
…d message display
fix(ui): improve picker deletion, ESC cancel, and SHIFT+ENTER path handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the updated keyboard-driven picker behaviors for directory mentions/navigation.
Behavior changes
Tab/Enter/Shift+Enterare now distinct actions while the Unified Picker is open (packages/ui/src/components/unified-picker.tsx).packages/ui/src/components/prompt-input/usePromptPicker.ts):Tab: autocomplete directory name and keep navigating (shows directory contents via picker query update).Enter: attach the directory as afileattachment withmime: inode/directory(sent as a FilePart pointing at afile://...directory URL).Shift+Enter: attach the directory path astextonly (no contents).Tab: autocomplete file path only (no attachment).Enter: attach file (existing behavior).Shift+Enter: attach file path astextonly (no contents).Notes
Changeset
packages/ui/src/components/unified-picker.tsxpackages/ui/src/components/prompt-input/usePromptPicker.tsTest status
npm run typecheckhere because dependencies are not installed in this bot workspace (tsc fails resolving packages likesolid-js,zod, etc.).--
Yours, CodeNomadBot