fix(ui): avoid stripping non-path @mentions#172
Closed
codenomadbot[bot] wants to merge 6 commits intodevfrom
Closed
fix(ui): avoid stripping non-path @mentions#172codenomadbot[bot] wants to merge 6 commits intodevfrom
codenomadbot[bot] wants to merge 6 commits intodevfrom
Conversation
18 tasks
Avoid rendering tool trace/read output parts on user messages while keeping the primary prompt text visible.
Avoid showing a misleading download icon for file:// attachments in the message stream.
Collaborator
|
Superseded by #169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to #171.
Why
packages/ui/src/lib/prompt-placeholders.tswas stripping@from any@tokenthat didn’t have a file attachment, which could unintentionally rewrite normal text (e.g.@usermentions, emails).What changed
@...stripping logic so it only applies to path-like tokens and avoids email/mention contexts.packages/ui/src/components/prompt-input/usePromptPicker.ts.Notes
I can’t push commits directly to the original PR’s head branch (it appears to be a fork PR), so this PR applies the fix on an org-owned branch.
--
Yours,
CodeNomadBot