Skip to content

temporal_capi: init at 0.1.2 #461195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FliegendeWurst merged 1 commit into from
Nov 16, 2025
Merged

temporal_capi: init at 0.1.2 #461195

FliegendeWurst merged 1 commit into from
Nov 16, 2025

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 13, 2025 •
edited
Loading

https://github.com/boa-dev/temporal/tree/main/temporal_capi

I need it to build Node.js with Temporal support

Things done

I've tested it with nodejs/node#60701 and both macOS and NixOS (ARM, I don't have a x86 machine).

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 13, 2025
@aduh95 aduh95 force-pushed the temporal-capi branch 4 times, most recently from e5bce20 to 211e5f6 Compare November 13, 2025 11:35
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 13, 2025

Hum OfBord is getting Error fetching system time, I'll have to look if we can work around that or have to skip those tests

@aduh95 aduh95 marked this pull request as draft November 13, 2025 13:44
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 13, 2025
@aduh95 aduh95 marked this pull request as ready for review November 13, 2025 19:37
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 13, 2025
@aduh95 aduh95 force-pushed the temporal-capi branch 7 times, most recently from 70b1c6f to a791da0 Compare November 14, 2025 11:58
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 14, 2025
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 16, 2025

The x64 darwin failure is related to #460791 (comment)

@FliegendeWurst FliegendeWurst added this pull request to the merge queue Nov 16, 2025
Merged via the queue into NixOS:master with commit 71cf367 Nov 16, 2025
29 of 30 checks passed
@aduh95 aduh95 deleted the temporal-capi branch November 16, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95 @FliegendeWurst