-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
build: add flag to compile V8 with Temporal support #60701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
aduh95:v8-enable-temporal-support
Nov 19, 2025
Merged
build: add flag to compile V8 with Temporal support #60701
nodejs-github-bot
merged 2 commits into
nodejs:main
from
aduh95:v8-enable-temporal-support
Nov 19, 2025
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
legendecas
approved these changes
Nov 13, 2025
Member
|
For static library support: #60703 :D |
56d6eed to
0a0185c
Compare
This was referenced Nov 14, 2025
Refs: nodejs#58730 Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
d5596f8 to
11024b0
Compare
Contributor
Author
|
Ping @nodejs/v8 for reviews |
legendecas
approved these changes
Nov 19, 2025
Collaborator
Collaborator
Collaborator
joyeecheung
approved these changes
Nov 19, 2025
Member
joyeecheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Side note: wondering if we would ever want to support "without Intl but with Temporal"..
Collaborator
Collaborator
Collaborator
|
Landed in eb6cb5b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B.: it only works if you provide the
temporal_capia shared library.I've tested it with:
nix-shell --arg withTemporal true --run 'make build-ci -j12'nix-shell --arg icu null --arg withTemporal true --run 'make build-ci -j12'nix-shell --argstr icu small --arg withTemporal true --run 'make build-ci -j12'I needed to apply the following patch, IIUC that's related to targeting a different version of
temporal_capi(already fixed upstream v8/v8@0cbecc1 and v8/v8@e0dc7e8), and V8 using some non-exposed ICU internals.The first commit is cherry-picked from #60693, cc @targos
Refs: #58730