Skip to content

matrix-synapse: move setuptools-rust back to build-system#481373

Merged
NickCao merged 1 commit into
NixOS:masterfrom
NickCao:matrix-synapse-unwrapped-fixup
Jan 19, 2026
Merged

matrix-synapse: move setuptools-rust back to build-system#481373
NickCao merged 1 commit into
NixOS:masterfrom
NickCao:matrix-synapse-unwrapped-fixup

Conversation

@NickCao
Copy link
Copy Markdown
Member

@NickCao NickCao commented Jan 18, 2026

Things done

Per https://github.com/element-hq/synapse/blob/27223a349c0cb5268782dc07b20f3450580165dc/pyproject.toml#L87, setuptools-rust, despite being in dependencies, should actually be in build-system. And this is causing build failure of synapse plugins.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@NickCao NickCao marked this pull request as draft January 18, 2026 17:49
@NickCao
Copy link
Copy Markdown
Member Author

NickCao commented Jan 18, 2026

Oops, this is causing runtime error.

@nixpkgs-ci nixpkgs-ci Bot added 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jan 18, 2026
@NickCao NickCao force-pushed the matrix-synapse-unwrapped-fixup branch from 4794bc3 to 222f131 Compare January 18, 2026 17:57
@NickCao NickCao marked this pull request as ready for review January 18, 2026 17:57
@NickCao
Copy link
Copy Markdown
Member Author

NickCao commented Jan 18, 2026

Oops, this is causing runtime error.

Fixed

@transcaffeine
Copy link
Copy Markdown
Member

Thank you for getting it to work again! What was the missing piece to fix the runtime error (i.e. why does your change work)?

@yuyuyureka
Copy link
Copy Markdown
Contributor

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 19, 2026
@teutat3s
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 481373 --package matrix-synapse --package nixosTests.matrix-synapse
Commit: 222f131923003c991dc47b190acf0d34a56baaf6


aarch64-linux

✅ 1 test built:
  • nixosTests.matrix-synapse
✅ 1 package built:
  • matrix-synapse

@teutat3s teutat3s added the backport release-25.11 Backport PR automatically label Jan 19, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 19, 2026
@NickCao NickCao added this pull request to the merge queue Jan 19, 2026
Merged via the queue into NixOS:master with commit 1c096d5 Jan 19, 2026
34 of 36 checks passed
@NickCao NickCao deleted the matrix-synapse-unwrapped-fixup branch January 19, 2026 21:55
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Jan 19, 2026

Successfully created backport PR for release-25.11:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 19, 2026
@teutat3s teutat3s mentioned this pull request Feb 11, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants