Skip to content

[18.0] [MIG] website_sale_wishlist_hide_price: Migration to 18.0 #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amkarthik wants to merge 7 commits into from
Closed

[18.0] [MIG] website_sale_wishlist_hide_price: Migration to 18.0 #1049

amkarthik wants to merge 7 commits into from

Conversation

@amkarthik
Copy link
Member

@amkarthik amkarthik commented Apr 23, 2025

Depends: #989

cc: @SodexisTeam

@SodexisTeam SodexisTeam force-pushed the 18.0-mig-website_sale_wishlist_hide_price branch 3 times, most recently from f8c3fdc to 7e9b590 Compare May 13, 2025 05:29
@pilarvargas-tecnativa
Copy link
Contributor

pilarvargas-tecnativa commented Jun 19, 2025

Hello, the PR for the dependency has been closed. In its place is this PR #1037

pilarvargas-tecnativa
pilarvargas-tecnativa suggested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new PR for the dependency. Could you please change it and do a rebase? Thanks.

#1082

@amkarthik amkarthik force-pushed the 18.0-mig-website_sale_wishlist_hide_price branch from 7e9b590 to 275c399 Compare July 22, 2025 08:29
@amkarthik
Copy link
Member Author

amkarthik commented Jul 22, 2025

There is a new PR for the dependency. Could you please change it and do a rebase? Thanks.

#1082

@pilarvargas-tecnativa
It's done, please check.
Thanks

@victoralmau
Copy link
Member

victoralmau commented Jul 30, 2025

The commit "[DON'T MERGE] test-requirements.txt" is no longer necessary (the PR indicated has already been merged).
Can you delete that commit?

@amkarthik amkarthik force-pushed the 18.0-mig-website_sale_wishlist_hide_price branch from 275c399 to 57c6197 Compare July 30, 2025 10:55
@amkarthik
Copy link
Member Author

amkarthik commented Jul 30, 2025

The commit "[DON'T MERGE] test-requirements.txt" is no longer necessary (the PR indicated has already been merged). Can you delete that commit?

@victoralmau
Done, thanks

victoralmau
victoralmau approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

TT54541

@pilarvargas-tecnativa
Copy link
Contributor

pilarvargas-tecnativa commented Jul 30, 2025

image

When you hide the price for a single product, the table looks a bit ugly. You could add the bottom border and remove the middle one.

@pilarvargas-tecnativa
Copy link
Contributor

pilarvargas-tecnativa commented Aug 13, 2025

Any news?

@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Aug 20, 2025
Merged
@pilarvargas-tecnativa
Copy link
Contributor

pilarvargas-tecnativa commented Aug 20, 2025

supersedes by #1100

@pedrobaeza pedrobaeza closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa requested changes

@victoralmau victoralmau victoralmau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amkarthik @pilarvargas-tecnativa @victoralmau @pedrobaeza @mymage @prabakaran04