-
-
Notifications
You must be signed in to change notification settings - Fork 534
[18.0][MIG] website_sale_hide_price: Migration to version 18.0 #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] website_sale_hide_price: Migration to version 18.0 #1082
Conversation
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/fa/
Currently translated at 75.0% (3 of 4 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/de/
…event show prices in cart (OCA#244) * Add to cart hidden if not website_show_price * Hide quantity selector * bump version and added contributor
add original validation of the view
Currently translated at 50.0% (2 of 4 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/it/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/de/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/sl/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_price/ca/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_price/es/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_hide_price/es_AR/
No we can hide the price only for the products we want to. TT36129
Adapt to the new base module feature
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/it/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/it/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es_AR/
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es_AR/
Currently translated at 100.0% (13 of 13 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/it/
Currently translated at 100.0% (13 of 13 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/it/
Fix caching of the website_sale.products view override. Before this commit, this module added a view that added two price website related cache keys to the products grid wrapper. In Odoo 17.0, caching was removed for this element. In combination with this module, this resulted in re-rendering this portion of the view, only depending on the cache keys added by this module. Because of it, searched products didn't update when changing any of the search parameters. This commit fixes it, by removing that override, and leaving the elements cache disabled.
Currently translated at 100.0% (13 of 13 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/sv/
Replaced view inheritance with Python logic in _website_show_quick_add to fix an issue where the "Add to Cart" button visibility was incorrectly overridden by this module. This update restores the expected behavior by ensuring the inherited logic determines button visibility.
|
/ocabot migration website_sale_hide_price |
juancarlosonate-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
afebbf7 to
dc0012b
Compare
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at daa661d. Thanks a lot for contributing to OCA. ❤️ |
Supersede to #1037
@Tecnativa TT54390
@CarlosRoca13 @juancarlosonate-tecnativa please review