Skip to content

Conversation

@pilarvargas-tecnativa
Copy link
Contributor

Supersede to #1037

@Tecnativa TT54390

@CarlosRoca13 @juancarlosonate-tecnativa please review

chienandalu and others added 30 commits July 17, 2025 13:25
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/fa/
Currently translated at 75.0% (3 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/de/
…event show prices in cart (OCA#244)

* Add to cart hidden if not website_show_price
* Hide quantity selector
* bump version and added contributor
Currently translated at 50.0% (2 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/sl/
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_price/ca/
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_price/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_hide_price/es_AR/
No we can hide the price only for the products we want to.

TT36129
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/it/
Currently translated at 100.0% (11 of 11 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es_AR/
ibuioli and others added 10 commits July 17, 2025 15:41
Currently translated at 100.0% (14 of 14 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es_AR/
Currently translated at 100.0% (13 of 13 strings)

Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/it/
Fix caching of the website_sale.products view override.

Before this commit, this module added a view that added two price website related cache keys to the products grid wrapper. In Odoo 17.0, caching was removed for this element. In combination with this module, this resulted in re-rendering this portion of the view, only depending on the cache keys added by this module. Because of it, searched products didn't update when changing any of the search parameters.

This commit fixes it, by removing that override, and leaving the elements cache disabled.
Currently translated at 100.0% (13 of 13 strings)

Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/sv/
Replaced view inheritance with Python logic in _website_show_quick_add
to fix an issue where the "Add to Cart" button visibility was
incorrectly overridden by this module. This update restores the
expected behavior by ensuring the inherited logic determines button
visibility.
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_hide_price

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 17, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 17, 2025
40 tasks
Copy link

@juancarlosonate-tecnativa juancarlosonate-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_hide_price branch from afebbf7 to dc0012b Compare July 22, 2025 15:28
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1082-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0a15600 into OCA:18.0 Jul 23, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at daa661d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-website_sale_hide_price branch July 23, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.