[FIX] mail_message_search : prevent db crach #72
Conversation
Before this commit a search in large database can crash, because the return of search() can include million of ids. This PR use SQL (and not python). A limit can be set to prevent a crash.
|
Hi @AungKoKoLin1997, @yostashiro, |
| domain = expression.AND([[("model", "=", self._name)], word_domain]) | ||
| messages = self.env["mail.message"].search(domain) | ||
| return [("id", "in", messages.mapped("res_id"))] | ||
| limit_value = self.env['ir.config_parameter'].sudo().get_param("mail.message.search.limit") |
There was a problem hiding this comment.
Something like this may follow the convention better.
| limit_value = self.env['ir.config_parameter'].sudo().get_param("mail.message.search.limit") | |
| limit_value = self.env['ir.config_parameter'].sudo().get_param("mail_message_search.message_limit") |
Can you please add the CONFIGURE file for this?
|
@fmdl Thanks for the fix. I backported this PR in my 17.0 migration PR and also added configuration file. |
|
Forgot to attach the backported commit in my above commend. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
4 participants
Before this commit a search in large database can crash, because the return of search() can include million of ids.
This PR use SQL (and not python).
A limit can be set to prevent a crash.