Skip to content

[FIX] mail_message_search : prevent db crach #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmdl wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] mail_message_search : prevent db crach #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mail_message_search/models/mail_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ def _search_message_search(self, operator, value):
word_domain_list.append(expression.OR(field_domain_list))
word_domain = expression.AND(word_domain_list)
domain = expression.AND([[("model", "=", self._name)], word_domain])
messages = self.env["mail.message"].search(domain)
return [("id", "in", messages.mapped("res_id"))]
limit_value = self.env['ir.config_parameter'].sudo().get_param("mail.message.search.limit")
Copy link
Member

@yostashiro yostashiro Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this may follow the convention better.

Suggested change
limit_value = self.env['ir.config_parameter'].sudo().get_param("mail.message.search.limit")
limit_value = self.env['ir.config_parameter'].sudo().get_param("mail_message_search.message_limit")

Can you please add the CONFIGURE file for this?

limit = int(limit_value) if limit_value else None
messages = self.env["mail.message"]._search(domain, limit=limit)
return [("id", "in", messages.subselect("res_id"))]

message_search = fields.Text(
help="Message search, to be used only in searches",
Expand Down
Loading