-
-
Notifications
You must be signed in to change notification settings - Fork 904
[MIG][12.0] Migrated purchase_exception to v12 #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][12.0] Migrated purchase_exception to v12 #609
Conversation
nikul-serpentcs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve Code
JayVora-SerpentCS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://travis-ci.org/OCA/purchase-workflow/jobs/458768228 Correction too.
fb12e22 to
8958464
Compare
8958464 to
169a469
Compare
|
Any more improvements / suggestions? |
|
@sudhir-erpharbor IMO Add oca_dependencies file,
Because Travis is fail here, depends module not available |
|
@sudhir-erpharbor squash commits @pedrobaeza could you please review code? |
florian-dacosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
The base_exception module has been refactored in version 10 (OCA/server-tools#1586)
The same is beeing done in version 12 and the refactore should be merged soon : OCA/server-tools#1589
This changes the way to implement sub modules (purchase_exception, sale_exception, etc...)
So this PR should be adapted to this new version. You can find an example with sale_exception module here : OCA/sale-workflow#860
@sudhir-erpharbor Can you adapt the module in this PR?
If necessary, I can eventually propose a PR with the module adapted to new version.
|
see the fix here to be compatible with new exception sudhir-erpharbor#1 Thanks to review |
FIX purchase_exception: update with major evolution of base_exception
|
It seems ready to merge. Could you approve @JayVora-SerpentCS and @florian-dacosta |
florian-dacosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment.
No really blocking but it would be appreciated to do it now.
|
Thanks! |
|
This PR has the |
This module depends on base_exception (server-tools) module.
Please review and give feedback.