Skip to content

Conversation

@GoodERPJeff
Copy link

No description provided.

sebalix and others added 30 commits October 13, 2018 14:21
…itlog.log' model (standard 'create_date' field is used instead)
…ail data - if any - are migrated during the installation)
… 'field_description' fields changed into related fields
@GoodERPJeff GoodERPJeff mentioned this pull request Oct 14, 2018
32 tasks
@elicoidal elicoidal added this to the 12.0 milestone Oct 14, 2018
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Some details
Good job!

'author':
"Akretion, Sodexis, Camptocamp, Odoo Community Association (OCA)",
'website': 'http://www.akretion.com',
'depends': ['base_setup'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add image key with screenshot cover to improve the apps store visibility

_order = 'active desc, sequence asc'

name = fields.Char('Exception Name', required=True, translate=True)
description = fields.Text('Description', translate=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically string is not necessary anymore when same as column name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not agree :)

@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add copyright

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref me some xml source link to follow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright is not needed, but you can view an example on this link
https://github.com/OCA/server-tools/blob/12.0/module_auto_update/views/ir_module_module.xml#L4

<field name="ignore" groups='base_exception.group_exception_rule_manager'/>
</group>
<footer>
<button name="action_confirm" string="_Close"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve format + copyright

@elicoidal
Copy link

not sure why runbot is failing cc @pedrobaeza

@pedrobaeza
Copy link
Member

Runbot has 2 warnings:

2018-10-14 13:10:53,772 150 WARNING openerp_test odoo.models: The model exception.rule.confirm has no _description
2018-10-14 13:10:53,772 150 WARNING openerp_test odoo.models: The model base.exception has no _description

@LoisRForgeFlow
Copy link
Contributor

Commit history need some ❤️

@pedrobaeza
Copy link
Member

Please take into account the PR #1231 for forward-porting here.

@angelmoya
Copy link
Member

@GoodERPJeff , will you work on this?

@pedrobaeza
Copy link
Member

Superseeded by #1557

@pedrobaeza pedrobaeza closed this Apr 9, 2019
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.