-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
12.0 mig base exception #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.0 mig base exception #1395
Conversation
… ones to make overridding easier
…itlog.log' model (standard 'create_date' field is used instead)
…S.txt file removed
…ail data - if any - are migrated during the installation)
… a field is deleted (e.g. migration)
… 'field_description' fields changed into related fields
12.0 mig base tecnical user
12.0 mig base exception
12.0 Migration base_cron_exclusion
12.0 mig auditlog
elicoidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Some details
Good job!
| 'author': | ||
| "Akretion, Sodexis, Camptocamp, Odoo Community Association (OCA)", | ||
| 'website': 'http://www.akretion.com', | ||
| 'depends': ['base_setup'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add image key with screenshot cover to improve the apps store visibility
| _order = 'active desc, sequence asc' | ||
|
|
||
| name = fields.Char('Exception Name', required=True, translate=True) | ||
| description = fields.Text('Description', translate=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically string is not necessary anymore when same as column name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not agree :)
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref me some xml source link to follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright is not needed, but you can view an example on this link
https://github.com/OCA/server-tools/blob/12.0/module_auto_update/views/ir_module_module.xml#L4
| <field name="ignore" groups='base_exception.group_exception_rule_manager'/> | ||
| </group> | ||
| <footer> | ||
| <button name="action_confirm" string="_Close" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve format + copyright
|
not sure why runbot is failing cc @pedrobaeza |
|
Runbot has 2 warnings: |
|
Commit history need some ❤️ |
|
Please take into account the PR #1231 for forward-porting here. |
|
@GoodERPJeff , will you work on this? |
|
Superseeded by #1557 |
Syncing from upstream OCA/server-tools (14.0)
No description provided.