FIX remove old api parameters in base_exception #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
requested changes
Apr 24, 2018
yvaucher
reviewed
Nov 19, 2018
yvaucher
approved these changes
Nov 20, 2018
mourad-ehm
approved these changes
Nov 20, 2018
Member
Author
|
ping @simahawk please could you check ? |
Member
Author
|
ping @pedrobaeza could you merge, please. Thanks |
Member
|
I suppose this should be forward-ported to v11. |
Member
Author
|
Done there #1433 |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @simahawk @mourad-ehm @jbeficent
thanks for a review